Ease of use methods in custom and simple form builder #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim203
requested changes
Jul 22, 2022
| * @since 1.1 | ||
| */ | ||
| @This | ||
| Builder optionalButton(@NonNull ButtonComponent button, boolean shouldAdd); |
There was a problem hiding this comment.
I'm not sure what the use of this method would be. If a button shouldn't be added then I'm not sure why the instance was created in the first place.
There was a problem hiding this comment.
I don't have use for directly adding buttons anymore, but if I did, it is true I would instead check if it should be shown, and then if not, just add a blank component instead of doing some placeholder work (in order to get button IDs to lineup). I'll remove this
| public Builder content(@NonNull String content) { | ||
| this.content = translate(Objects.requireNonNull(content, "content")); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public Builder button(@NonNull ButtonComponent button) { | ||
| buttons.add(button); |
Tim203
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ButtonComponenttoSimpleForm.BuilderandFormImagetoCustomForm.Builder@OverrideannotationsThis will allow for cleaner code when those objects have already been created from deserialization. Feel free to edit anything