Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive session server lookups (velocity & potential other platforms) #508

Closed
bridgelol opened this issue May 10, 2024 · 1 comment · Fixed by #509
Closed

Excessive session server lookups (velocity & potential other platforms) #508

bridgelol opened this issue May 10, 2024 · 1 comment · Fixed by #509
Labels
bug Something isn't working

Comments

@bridgelol
Copy link
Contributor

Floodgate currently forwards a "broken" gameprofile to velocity that does not contain any properties at all, causing paper instances to register this player as not having any textures and therefor fetching mojang's authservers which causes (invalid) api calls every time a bedrock player switches a server on velocity.

I've recently contributed a patch to paper to prevent them from looking up profiles when it's not needed:
PaperMC/Paper@21d91ce

After closely monitoring this and building my own system around it I noticed this only happens to bedrock players so I dug deeper and found out this a fundamental flaw within floodgate.

Even default minecraft java accounts that have never selected a skin still have the "textures" property in their gameprofile, either Steve or Alex. I suggest floodgate applies either one of these by default, will be pushing a PR for this, however would like some more feedback on this.

Steve: eyJ0aW1lc3RhbXAiOjE1MzIwOTIwMDAsInByb2ZpbGVJZCI6InBsYXllci11dWlkIiwicHJvZmlsZU5hbWUiOiJwbGF5ZXItbmFtZSIsInRleHR1cmVzIjp7IkZJTkFMIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvYjgyN2ViZmY3ZjJlZDVjM2I5ZTdiYzZhNTE5NjkzNjdmMzljYjMwZjk3YTc0NjViOWU5OGZkNDY5NGZmODAwZiJ9fX19

Alex: eyJ0aW1lc3RhbXAiOjE1MzIwOTIwMDAsInByb2ZpbGVJZCI6InBsYXllci11dWlkIiwicHJvZmlsZU5hbWUiOiJwbGF5ZXItbmFtZSIsInRleHR1cmVzIjp7IkZJTkFMIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvYTkxMjFkMjZjNzU2NzA2YzY3MTcyZjM3YzYxNzFlZDk4NmE2NDgzODc5MjlhODc0MDQ1OGY0MTE2YjYxIn19fQ==

@bridgelol
Copy link
Contributor Author

For further context, I believe the origin for this (in velocity) to be this event listener:

image

VelocityListener#onGameProfileRequest(GameProfileRequestEvent)

@onebeastchris onebeastchris added the bug Something isn't working label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants