-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce session server lookups #509
Conversation
Unsure if there's a better way than simply just sending an empty signature over. |
This should solve this bungee & spigot-side as well (bungee doesn't need modifying as it doesn't have modern forwarding like velocity, fixing spigot also fixes bungee) |
velocity/src/main/java/org/geysermc/floodgate/listener/VelocityListener.java
Outdated
Show resolved
Hide resolved
https://github.com/GeyserMC/Floodgate/blob/master/spigot%2Fsrc%2Fmain%2Fjava%2Forg%2Fgeysermc%2Ffloodgate%2Flistener%2FPaperProfileListener.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One functional thing to keep in mind is that with this PR you always prevent the skin lookup, while you still want to do a skin lookup when the player is linked.
When a player is linked it acts like it's the linked Java player (including the same UUID etc.), meaning that it should also have the skin of the Java player. Which is something we don't store, and has to be looked up like normal.
Yep, believe this would be ideal. 33fd6ac |
Would you recommend not adding the properties if the player is linked? |
Or, alternatively, look them up ourselves? |
If the player is linked, the Java server will see a valid Java username/uuid, and should look up textures for that player |
spigot/src/main/java/org/geysermc/floodgate/addon/data/SpigotDataHandler.java
Outdated
Show resolved
Hide resolved
I believe we should be doing skin lookups on velocity ourselves then, having spigot handle it if floodgate's ran purely on spigot is fine, however you don't want spigot instances doing a new lookup every time a player switches server on velocity (modern forwarding). |
Should be good to merge now |
Co-authored-by: Bridge <29434554+bridgelol@users.noreply.github.com>
Fixes #508, fixes #478.