Open advancement tab regardless of currently open tab (#4665)

GeyserMC · May 20, 2024 · a780eea · a780eea
1 parent 8b77031
commit a780eea
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/core/src/main/java/org/geysermc/geyser/session/cache/AdvancementsCache.java b/core/src/main/java/org/geysermc/geyser/session/cache/AdvancementsCache.java
@@ -91,15 +91,13 @@ public void buildAndShowMenuForm() {
         builder.validResultHandler((response) -> {
             String id = rootAdvancementIds.get(response.clickedButtonId());
             if (!id.equals("")) {
-                if (id.equals(currentAdvancementCategoryId)) {
-                    // The server thinks we are already on this tab
-                    buildAndShowListForm();
-                } else {
-                    // Send a packet indicating that we intend to open this particular advancement window
+                if (!id.equals(currentAdvancementCategoryId)) {
+                    // Send a packet indicating that we are opening this particular advancement window
                     ServerboundSeenAdvancementsPacket packet = new ServerboundSeenAdvancementsPacket(id);
                     session.sendDownstreamGamePacket(packet);
-                    // Wait for a response there
                 }
+                currentAdvancementCategoryId = id;
+                buildAndShowListForm();
             }
         });