Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot craft shield using multiple wood types. #3784

Closed
DesolateIntention opened this issue May 21, 2023 · 2 comments · Fixed by #4016
Closed

Cannot craft shield using multiple wood types. #3784

DesolateIntention opened this issue May 21, 2023 · 2 comments · Fixed by #4016
Labels
Confirmed Bug The bug reported is confirmed and able to be replicated.

Comments

@DesolateIntention
Copy link

Describe the bug

When placing more than one type of wood on the crafting table and trying to create a shield on Bedrock, it will not work.

To Reproduce

  1. Put different types of wood on the crafting table (like oak and birch).
  2. Put it in the shield recipe configuration.

No shield will be crafted.
SmartSelect_20230521_175952_Minecraft

Expected behaviour

Shield will be crafted.
image

Screenshots / Videos

No response

Server Version and Plugins

1.19.4.
ViaVersion, Dynmap, LuckPerms, NoEncryption, PlaceholderAPI, Plugman, Spark.
I do not have more information.

Geyser Dump

https://dump.geysermc.org/klBnvjaGSPIuoElOLNuhmef50JZXlh4i

Geyser Version

2.1.0-SNAPSHOT (git-master-1e79aa9)

Minecraft: Bedrock Edition Device/Version

Android 13. Minecraft Bedrock 1.19.83.

Additional Context

No response
@Konicai Konicai added the Confirmed Bug The bug reported is confirmed and able to be replicated. label May 22, 2023
@Konicai
Copy link
Member

Konicai commented May 22, 2023 •
edited
Loading

Shield recipe Ingredient[] received by Geyser: https://paste.gg/p/anonymous/2df9ba14759046fd98bc61d3b50656e5/files/7c23eec361e0465aaa87f72c1a7f5ae9/raw

Combination array that Geyser generated: https://paste.gg/p/anonymous/d614ca07efa6422ab780287f44fd02f5
(ItemDescriptors of the ItemDescriptorWithCounts)

@MrBsng
Copy link

MrBsng commented Aug 18, 2023

I can craft shield using multiple wood types on paper server version 1.20.1 with bedrock client 1.20.12.

@onebeastchris onebeastchris mentioned this issue Aug 19, 2023
Merged
6 tasks
onebeastchris added a commit to onebeastchris/Geyser that referenced this issue Aug 19, 2023
@onebeastchris
Use itemTag descriptors to fix GeyserMC#3784
81d7386
@onebeastchris onebeastchris added the Work in Progress The issue is currently being worked on. label Aug 19, 2023
@onebeastchris onebeastchris linked a pull request Nov 3, 2023 that will close this issue
Feature: Add recipe unlocking on Bedrock edition #4016
Merged
6 tasks
onebeastchris added a commit that referenced this issue Nov 10, 2023
@onebeastchris
Feature: Add recipe unlocking on Bedrock edition (#4016)
9dad1ac 
* Start on 1.20.10+ recipe unlocking system

* Keeping track of multiple Bedrock recipes to unlock for a single Java recipe

* Unlock stonecutter recipes

* Stonecutter recipes

* Unlock tipped arrows/shulker box recipes even when Java doesnt (why..?), and dont send trims if Java doesn't

* Translate FurnaceDataRecipes

* Revert FurnaceRecipe translation, revert stone cutter recipe identifier caching - Bedrock does not need the smelting recipe, and doesn't (un)lock stonecutter recipes (yet...?)

* Remove debug message

* Make decorated pot crafting just a little bit smoother :p

* formatting

* Use itemTag descriptors to fix #3784

* Use hashmap instead to store item tag overrides

* remove unnecessary comment

* Address review by @Konicai

* Support for 1.20.30

* undo add whitespace

* Merge upstream, use FastUtil maps, rename a few methods

* Address Camotoy's review

* Fix formatting
@onebeastchris onebeastchris removed the Work in Progress The issue is currently being worked on. label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug The bug reported is confirmed and able to be replicated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Add recipe unlocking on Bedrock edition onebeastchris/Geyser
4 participants
@MrBsng @DesolateIntention @Konicai @onebeastchris