Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1774

Merged
merged 2 commits into from
Jan 3, 2021
Merged

Update README.md #1774

merged 2 commits into from
Jan 3, 2021

Conversation

colinsantos
Copy link
Contributor

Add v1.16.201 in list of supported Bedrock versions

Add v1.16.201 in list of supported Bedrock versions
@Creeperz653
Copy link
Sponsor

umm

@YHDiamond
Copy link
Contributor

yes this should be added

README.md Outdated
@@ -18,7 +18,7 @@ The ultimate goal of this project is to allow Minecraft: Bedrock Edition users t

Special thanks to the DragonProxy project for being a trailblazer in protocol translation and for all the team members who have now joined us here!

### Currently supporting Minecraft Bedrock v1.16.100/v1.16.101/v1.16.200 and Minecraft Java v1.16.4.
### Currently supporting Minecraft Bedrock v1.16.100/v1.16.101/v1.16.200/v1.16.201 and Minecraft Java v1.16.4.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, it might be better separated by commas? v1.16.100, v1.16.101, v1.16.200, v1.16.201.

@YHDiamond
Copy link
Contributor

or v1.16.100 - v1.16.201 maybe

Change to `v1.16.100 - v1.16.201`
@Hellohi3654
Copy link
Contributor

are v1.16.100 and v1.16.101 fully supported?

@Camotoy
Copy link
Member

Camotoy commented Jan 2, 2021

Fully? I would say that any bugs only present on them will not be fixed, but yes, they are supported.

@Hellohi3654
Copy link
Contributor

Ok thanks

@Camotoy Camotoy merged commit 3f7d669 into GeyserMC:master Jan 3, 2021
@croesch
Copy link

croesch commented Jan 10, 2021

If I try to connect from a bedrock version 1.16.201 it says that maximum supported version is 1.16.200.5. Are you sure that version 1.16.201 is supported? I'm running build 574 from today..

If not, what would I have to do to be able to connect to the geyser version, can the maximum version be tweaked in a file or would this require some protocol changes?

@Camotoy - thx in advance!

@YHDiamond
Copy link
Contributor

Please go to geyser discord (discord.geysermc.org) and run !!ping in #bot-spam there. After that, go to a support channel and we can answer your question.

@Camotoy
Copy link
Member

Camotoy commented Jan 10, 2021

I don't mind the "ping", though it's more of a "mention" on GitHub.

1.16.201 is compatible with 1.16.200.

@croesch
Copy link

croesch commented Jan 10, 2021

OK I understand that reviving an old PR is not the preferred way to connect to you ;-) I'll ask in discord later because I got really frustrated today trying to connect my phone MC to a Java server using Geyser either standalone or as a plugin. Both failed with the same message and connection was not possible ..

I was just curious if I could figure out the point of code where some kind of version check would happen. All I found was com.github.CloudburstMC.Protocol:bedrock-v422:d41b84e86c in connector/pom.xml which I also updated. But the built result was not different in outcome.

@Camotoy
Copy link
Member

Camotoy commented Jan 10, 2021

Version checking happens here: https://github.com/GeyserMC/Geyser/blob/master/connector/src/main/java/org/geysermc/connector/network/UpstreamPacketHandler.java#L62, and it accepts 1.16.201 fine because its protocol version is 422. If you are getting zero logs from Geyser, then that implies a connection issue where Geyser cannot be reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants