Update CONTRIBUTING.md #1787
Update CONTRIBUTING.md #1787
Conversation
Ok that works to but i meant for that to mean 'put all your annotation stuff here' obviously it wont compile, but this works too Co-authored-by: theminecoder <theminecoder@users.noreply.github.com>
|
Any news on this |
|
Are there any compilation issues (besides using variable names that don't exist, etc) that I should fix? |
|
Just to note: @lukeeey sent a form for contributors to fill out, and one of the questions asked about the CONTRIBUTING.md. This will hopefully make people's 'review' of the CONTRIBUTING.md 10/10 |
|
@YHDiamond I actually discovered the other day that the contributing guidelines aren't just for how you format your code. They can also cover creating PRs as well as issues, but don't worry about that right now. Here is some very good contribution guidelines: https://github.com/PaperMC/Paper/blob/master/CONTRIBUTING.md |
|
Ok, but the contributing guidelines should contain good code, right? If they don't contain good code it is embarrassing (imo). |
|
Yeah |
|
thank you. now we must wait for the all powerful merge power to come by |
|
Any news on this? Will it be merged? |
there were a few code mistakes in this previous contributing.md which probably made a bad impression. so I fixed that and added a few more things