Projectile Movement #1929
Projectile Movement #1929
Conversation
...r/src/main/java/org/geysermc/connector/network/translators/world/block/BlockStateValues.java
Outdated
Show resolved
Hide resolved
.../org/geysermc/connector/network/translators/java/entity/spawn/JavaSpawnEntityTranslator.java
Show resolved
Hide resolved
| @@ -117,8 +182,10 @@ protected float getDrag(GeyserSession session) { | |||
| */ | |||
| protected boolean isInWater(GeyserSession session) { | |||
| if (session.getConnector().getConfig().isCacheChunks()) { | |||
| int block = session.getConnector().getWorldManager().getBlockAt(session, position.toInt()); | |||
| return block == BlockTranslator.BEDROCK_WATER_ID; | |||
| if (0 <= position.getFloorY() && position.getFloorY() <= 255) { | |||
There was a problem hiding this comment.
Just as a general note, it might be a better idea to move this as a precheck for getBlockAt. You can get a similar error if you place a block at Y256 because of the resulting block update packet. No need to change this code for the time being, and you're certainly not obligated to do this yourself - this change belongs in a separate PR.
connector/src/main/java/org/geysermc/connector/entity/FishingHookEntity.java
Outdated
Show resolved
Hide resolved
|
Poggers |
connector/src/main/java/org/geysermc/connector/entity/ThrowableEntity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/ThrowableEntity.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/AbstractArrowEntity.java
Show resolved
Hide resolved
connector/src/main/java/org/geysermc/connector/entity/AbstractArrowEntity.java
Outdated
Show resolved
Hide resolved
|
Game-wise, everything looks fine, except. I threw my fishing rod and I started lagging client-side - my frames just dropped, and this did not happen without this PR. I'm not sure why, but I'm happy to help look tomorrow if need be. |
|
Very strange, I can confirm this happens on an IPad Air, but not on Windows 10 edition. It seems to be due to the bounding box height I've set in the constructor. |
| @@ -47,4 +49,17 @@ public void updateBedrockMetadata(EntityMetadata entityMetadata, GeyserSession s | |||
|
|
|||
| super.updateBedrockMetadata(entityMetadata, session); | |||
| } | |||
|
|
|||
| @Override | |||
| public void setRotation(Vector3f rotation) {} | |||
There was a problem hiding this comment.
Add a comment in the method body explaining the arrow rotation, if you would.
Fixes
Needs GeyserMC/mappings#50