Cloud for commands

[Konicai]

changes

• GeyserCommandManager has been renamed to CommandRegistry

• GeyserCommandExecutor and all subclasses have been removed in favour of Cloud.

• WorldManager#hasPermission has been removed in favour of Cloud.

• permission node for the root command of Geyser and extensions, that is required to use any child commands

• Spigot

  • no longer depends on paper mojang api.
  • GeyserBrigadierSupport has been removed in favour of Cloud.
  • GeyserPaperCommandListener has been removed - cloud (and the way i designed permission checks) handles what it did.

• Standalone/ViaProxy:

  • permissions.yml has been added, a list of default permissions available to all players.

• Velocity/BungeeCord/Fabric/Standalone: commands are now registered before GeyserPostInitializeEvent, for consistency with Spigot, and to allow valid registration on Fabric.

  • There is still inconsistency between bootstraps on whether or not commands are re-registered whenever a reload occurs.

api changes:

deprecations

• Command#isSuggestedOpOnly and the relevant builder method have been deprecated for removal
• Command#subCommands has been deprecated for removal and will always return Collections.emptyList()
• Command#isExecutableOnConsole() has been deprecated & replaced with #isPlayerOnly()

changes

• Command#aliases() now always returns an immutable list

additions

• Command.Builder#permission(String, Tristate) - register the permission and its default value to the server implementation if possible.
• CommandSource#playerUuid - return a uuid if the source represents a player.
• CommandSource#connection - return a Connection if the source represents a bedrock player managed by the current Geyser instance.

---

• GeyserRegisterPermissionCheckersEvent - only used by Geyser-Standalone/ViaProxy. Fired when the command manager is created. Allows registering PermissionCheckers to the manager. Event listeners with a higher listener priority will register PermissionCheckers as having a higher priority.
• PermissionChecker - api interface that is responsible for resolving a CommandSource and a permission node to a Tristate.

---

• GeyserRegisterPermissionsEvent - fired by a server platform, or extension, or anything, when it is the proper time for permissions to be registered to the event caller. This event will be called by Geyser-Spigot/Standalone/Forge. An extension may also fire the event in order to register permissions to LuckPerms for Geyser-Velocity/BungeeCord/Fabric. Geyser's CommandRegistry will listen for this event, but api users may as well.

future and separate PRs

• implementations of CommandSource#sendMessage are wildly different in terms of what kind of text format is passed to it. maybe an earlier PR.
• use cloud's brigadier mappings to get suggestions on geyser standalone
• add tab completion to geyser standalone JLine
• revisit Command.Builder#permisssion(String, TriState)
• geyser.command.exthelp.<id> can be changed to something better during The Merge

todo:

• the lack of permissions on standalone. what this causes needs to be cleaned up, at least in extension commands.
• create permissions.yml file for standalone/viaproxy
• remove standalone permission hacks from builtin cmmands
• isSuggestedOpOnly is kind of problematic imo, in regards to its wording and the way it is used. it can probably just be deprecated in favour of optional permission registration
• properly handle stopping execution due to isExecutableOnConsole or isBedrockOnly with descriptive messages
• exceptions are completely unhandled on Geyser-Standalone right now
• convert builtin commands to fully utilize cloud features
• pretty sure just /geyser is suppose to send help?
• localize all messages
• deal with possible trailing whitespace on geyser standalone gui
• java players get suggested bedrock only commands -> additionally add platform check as a permission predicate
• restore Spigot COMMAND_MAP lookup for descriptions
• search CommandRegistry for our own description(s)
• javadocs
• check if we need to strip trailing whitespace before dispatching to cloud from BedrockCommandRequestTranslator (when Geyser Standalone is in use)
• fix certain commands not working properly with handleNoPermission
• i think command.failed lang might be broken
• ensure viaproxy doesn't error on the clearing of the command manager when viaproxy was initialized, but not started
• Spigot has a root command permission. fix regression of it being removed.
• ensure all extension command permissions are registered on NeoForge, regardless of permission defaults. maybe just change the overall handling.
• Fabric/NeoForge ClientCommandManager?
• final testing

[onebeastchris]

One nitpick; also the @NonNull nature of the permission/permission default on the permission registration event doesn't seem to be enforced at the moment