Players spawn, skins and capes, scoreboard, bossbar, fixes and updated protocol lib #41
Conversation
|
Finally had some time to sit down and take a look through this. From what I could see, the code looked fine, however I've not yet had time to test this. I'll do some testing of my own tomorrow but if anyone else wants to try this out, please feel free to do so. |
|
I have tested the skins, the players spawn correctly. The only things I haven't tested are bossbars and scoreboards. And now I'm implementing optifine capes on local |
|
Thanks for testing (I wanted some tests before pushing), but I already have the code local for optifine capes (and some other mods) |
.../geysermc/connector/network/translators/java/entity/spawn/JavaPlayerListEntryTranslator.java
Outdated
Show resolved
Hide resolved
|
I get this error and I can't see players Could not translate packet ServerPlayerListEntryPacket
null
.Haven't received PlayerListEntry packet before spawning player! We ignore the player 4f5d306b-17ca-34b2-bea9-bacc6907e17c``` |
|
@Heath123 i got same issue i discusted it with tim on discord geyser chat |
|
Oh, OK |
|
@WesleyVanNeck What's your Discord name? |
|
also, i got the same error too. |
EOT3000
requested review from
LogicismDev,
Redned235 and
EOT3000
and removed request for
LogicismDev,
Redned235 and
EOT3000
|
Gravity appears to be sent too late, which likely has to do with the issues mentioned in #52. I was launched up into the air and then when everything else loaded, I fell to the ground. Most times, the anticheat detection would kick me off. |
|
That shouldn't possible because it is one of the first packet to be sent (JoinGame), and enabling gravity the last one (in the queue). I don't have any moved too quickly on the servers (and localhost) I tried. And I guess that the CPU spike is caused by the rapidly sent packets after the packetqueue is unfrozen (and the fact that the client keeps connected after he logged out and gets disconnected after the new connected logged in) |
Tim203
changed the title
|
Did some testing with the latest commit. Players appear only to be added to the player list when in range. If a player is not within my view distance, they are not added to the player list. However when I teleport away from the player added, they are still in the player list. Not sure if this is expected behavior. As for gravity, I tested this a few times on multiple different servers and didn't have any issues upon first join. However, when switching servers or changing worlds, I was sent up in the air a few times, due to the gravity attribute not being set. Roughly 3/5 switches I was sent up in the air and able to fall back down and not crash. Only on one occurrence did I crash from being sent up too high. |
|
I removed the gravity. And the playerlist is expected when I look at the code, but was not my intension |
|
Seems good from my testing and haven't ran into any more issues. Merging. |
This probably isn't needed anymore. This was introduced in #41 and is probably no longer needed since we never send movement before the player is spawned, and we don't allow movement to go through until the Bedrock player matches the unconfirmed teleport we create in JavaPlayerPositionTranslator. By removing this we should fix some instances of players kicked for 'flying' as players joining in the air would never respond to gravity until Bedrock finished loading.
No description provided.