Book cloning fix #4784
Open
Book cloning fix #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camotoy
reviewed
Jun 22, 2024
| /** | ||
| * Book cloning recipe ID; stored separately as its recipe works differently from others. | ||
| */ | ||
| public static final int BOOK_CLONING_RECIPE_ID = 278; |
There was a problem hiding this comment.
This can't be hardcoded, as it could differ between two sessions on standalone working with different recipes.
| @@ -376,7 +382,7 @@ private void reduceCraftingGrid(boolean makeAll) { | |||
| for (int i = 0; i < gridSize; i++) { | |||
| final int slot = i + 1; | |||
| GeyserItemStack item = getItem(slot); | |||
| if (!item.isEmpty()) { | |||
| if (!item.isEmpty() && (!handleBookRecipe || item.getJavaId() != session.getItemMappings().getStoredItems().writtenBook().getJavaItem().javaId())) { | |||
There was a problem hiding this comment.
The second comparison can now be item.asItem() == Items.WRITTEN_BOOK
onebeastchris
added
PR: Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix to allow copying books to work 100% of the time and closes #3682. This is an adaption of a patch Camotoy wrote a few years ago, I changed it to work with the modern codebase and fixed an issue or two. This needs more testing to ensure that it works 100% of the time and that it doesn't break any existing crafting recipes. The code can likely be rewritten to be neater and more modular but I did not get around to that yet.