Fix painting offset on versions older than 1.19 #4792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3014.
This happens because ViaVersion adds the offset of 0.5, and then Geyser adds the offset of 0.5, resulting in the buggy positioning.
https://github.com/ViaVersion/ViaVersion/blob/dd1fad2dd736b3385f74ce375ebd47ea2d23daba/common/src/main/java/com/viaversion/viaversion/protocols/v1_18_2to1_19/rewriter/EntityPacketRewriter1_19.java#L104
Tested on Latest Bungeecord -> Paper 1.8.8 and on Paper 1.21