Fallback to ViaVersion to convert block state #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't PR this until I take a look at using this with newer versions of ViaVersion. |
|
As of right now, ViaVersion compatibility only works with 3.0.0-SNAPSHOT, and it will give an error if you try to use a different version. This PR is safe to review and merge. |
Redned235
requested changes
May 9, 2020
bootstrap/bukkit/src/main/java/org/geysermc/platform/bukkit/world/GeyserBukkitWorldManager.java
Outdated
Show resolved
Hide resolved
bootstrap/bukkit/src/main/java/org/geysermc/platform/bukkit/GeyserBukkitPlugin.java
Outdated
Show resolved
Hide resolved
bootstrap/bukkit/src/main/java/org/geysermc/platform/bukkit/world/GeyserBukkitWorldManager.java
Show resolved
Hide resolved
Redned235
requested changes
May 9, 2020
bootstrap/bukkit/src/main/java/org/geysermc/platform/bukkit/world/GeyserBukkitWorldManager.java
Show resolved
Hide resolved
Redned235
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most users will be using ViaVersion if their server version is below 1.13, this code uses ViaVersion's code to get the correct block state for chunk caching on Bukkit. (And if ViaVersion is not installed, the air block state should be returned instead of giving a NPE)