Inventory Transactions (Work in Progress) #67

AJ-Ferguson · 2019-10-20T23:40:29Z

Work in progress.
Testing is wanted and edits are welcomed.

List of things that should be working:

Basic left/right clicking
Shift clicking
Double clicking to fill stack
Touchscreen
Dropping items
Using menus in custom servers (Hypixel, Mineplex, etc.)
Opening Basic Containers
Crafting
Item spreading
Creative mode
Enchanted items
Basic potions

List of known issues:

Custom potions
Some windows have not been implemented yet
- Enchanting Table
- Beacon
- Cartography Table
- Lectern
- Loom
- Stonecutter
- Villager Trading
Changing the cursor. The bedrock client is bugged when changing the cursor. (Fixed in BE 1.14)

getChunkBlock() in ChunkPosition returned incorrect values when negative numbers were inputted. ChunkPosition did not function correctly when used as a key for maps because it did not override equals() and hashCode()

work in progress

Mineplex server seemed to be sensitive about quotes in string tags

FrostNovaHD · 2019-10-21T11:33:03Z

@AJ-Ferguson right click on bukkit is inverted i got long tab it ehh and 1 row chest gui is litlte ampty so could fill that with glass panes or soemting?

Flonja · 2019-10-21T12:31:38Z

Do chests that aren't 3 or 6 rows work?

FrostNovaHD · 2019-10-21T12:32:15Z

yes they do

connector/src/main/java/org/geysermc/connector/inventory/Inventory.java

connector/src/main/java/org/geysermc/connector/network/translators/item/ItemTranslator.java

...main/java/org/geysermc/connector/network/translators/java/world/JavaChunkDataTranslator.java

FrostNovaHD · 2019-10-22T14:08:25Z

there are two bugs one of them i cant rigtclick on a item

seccond one is in kits gui there is close item and a back item both dont work

both in touch and and mouse and keyboard

FrostNovaHD · 2019-10-22T16:37:59Z

also i did get a error

�[31;1mCould not translate packet ServerSetSlotPacket java.lang.ArrayIndexOutOfBoundsException: 45�[0m java.lang.ArrayIndexOutOfBoundsException: 45 at org.geysermc.connector.network.translators.java.window.JavaSetSlotTranslator.translate(JavaSetSlotTranslator.java:79) at org.geysermc.connector.network.translators.java.window.JavaSetSlotTranslator.translate(JavaSetSlotTranslator.java:43) at org.geysermc.connector.network.translators.Registry.translate(Registry.java:54) at org.geysermc.connector.network.session.GeyserSession$1.packetReceived(GeyserSession.java:186) at com.github.steveice10.packetlib.event.session.PacketReceivedEvent.call(PacketReceivedEvent.java:51) at com.github.steveice10.packetlib.tcp.TcpSession.callEvent(TcpSession.java:143) at com.github.steveice10.packetlib.tcp.TcpSession$3.run(TcpSession.java:343) at java.lang.Thread.run(Thread.java:748)

Fix offhand, use AtomicInteger for transaction id, send null stack instead of air, and clear open inventory on dimension change

AJ-Ferguson · 2019-10-22T23:46:30Z

there are two bugs one of them i cant right click on a item

I don't think it is possible to fix that. The bedrock client does not send whether the user left or right clicked, only the changed amounts. I made it default to left clicking on a 1 item stack.

EDIT: To clarify, I'm talking about differentiating a left or right click on an item stack containing one item.
It is of course possible to find out which click it was on an item stack containing more than one item using simple math.

EOT3000 · 2019-10-22T23:57:20Z

pspe does it so press+hold = double click

EOT3000 · 2019-10-23T00:07:45Z

*right click

FrostNovaHD · 2019-10-23T06:32:42Z

there are two bugs one of them i cant right click on a item

I don't think it is possible to fix that. The bedrock client does not send whether the user left or right clicked, only the changed amounts. I made it default to left clicking on a 1 item stack.

Indeed what @EOT3000 says in pspe It works so why cant you get It to work?

FrostNovaHD · 2019-10-23T06:45:32Z

@AJ-Ferguson https://github.com/LegacyGamerHD/LoyaltyMC-pspe/blob/main_loyalty/src/protocolsupport/protocol/typeremapper/pe/inventory/PETransactionRemapper.java

FrostNovaHD · 2019-10-23T06:56:00Z

Also this might help also https://github.com/ProtocolSupport/ProtocolSupport/wiki/PSPE:-GodPacket

FrostNovaHD · 2019-10-23T06:57:52Z

this also https://github.com/ProtocolSupport/ProtocolSupport/wiki/PSPE:-Inventory-Managing

Kasjuhh · 2019-10-29T09:44:30Z

A dropper gets seen as a Dispenser on bedrock side

Kasjuhh · 2019-10-29T09:46:57Z

Clicking on Y on an item to shift click it doesnt work on armor. Tps item back to original spot

Some translation identifiers such as "container.blast_furnace" are not being translated yet

anvil, brewing stand, crafting table (still no crafting yet), shulker box

ghost · 2020-01-03T23:03:23Z

Is this going to continue?

# Conflicts: # connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java # connector/src/main/java/org/geysermc/connector/network/translators/TranslatorsInit.java # connector/src/main/java/org/geysermc/connector/network/translators/java/JavaRespawnTranslator.java

Encritary · 2020-01-08T05:44:40Z

Cursor change bug was actually fixed in 1.14

AJ-Ferguson · 2020-01-08T13:54:45Z

I'm currently rewriting most of the inventory code. The cursor will be handled properly in the rewrite now that the bug is fixed.

FrostNovaHD · 2020-01-08T17:59:15Z

What's different in rewrite then how it's in it current state its usable and stable only thing I cant is do q to drop a item or tab hold it to right click in custom inventory and I made workarounds for that a custom inventory for it

Pecacheu · 2020-01-22T22:24:03Z

Inventory management is working perfectly for me in the current release, only crafting does not work, nothing shows in the output slot.

EDIT: Never mind, must have downloaded from master branch instead of the pull request, crafting is working.

Still much to do. Inventory desyncing when crafting will be fixed soon.

This fixes the NPE when sending an ItemStack with a null NBT tag. This also fixes some item movement bugs on pure vanilla servers.

Daisreich

Very good!

# Conflicts: # connector/src/main/java/org/geysermc/connector/network/translators/TranslatorsInit.java # connector/src/main/java/org/geysermc/connector/utils/Toolbox.java

Quick fix. Might have a different method for getting block IDs in the future

# Conflicts: # connector/src/main/java/org/geysermc/connector/network/translators/TranslatorsInit.java # connector/src/main/java/org/geysermc/connector/network/translators/inventory/updater/ChestInventoryUpdater.java

FrostNovaHD · 2020-03-23T19:51:17Z

Right click doesn't work in costom inventories like previewing a kit

FrostNovaHD · 2020-03-23T19:51:47Z

Some times a item ghost around in the costom inventories

Update Master

AJ-Ferguson added 8 commits October 19, 2019 23:54

Use chunk cache and fix ChunkPosition

3067c72

getChunkBlock() in ChunkPosition returned incorrect values when negative numbers were inputted. ChunkPosition did not function correctly when used as a key for maps because it did not override equals() and hashCode()

Work on inventory transactions

88648f7

work in progress

Remove debug messages

3812712

Add delay when reopening inventory

8ae803b

Update JavaSetSlotTranslator.java

06358b2

Close open inventory before opening a new one

4074582

Uncache chunks

08357ed

Fix item nbt translator

12c0497

Mineplex server seemed to be sensitive about quotes in string tags

Redned235 marked this pull request as ready for review October 21, 2019 22:52

Redned235 reviewed Oct 21, 2019

View reviewed changes

Redned235 added the Work in Progress The issue is currently being worked on. label Oct 21, 2019

Revert storing chunks in chunk cache

38fd537

Various fixes

24c27a0

Fix offhand, use AtomicInteger for transaction id, send null stack instead of air, and clear open inventory on dimension change

AJ-Ferguson added 3 commits November 1, 2019 01:07

Add inventory names

5797dc2

Some translation identifiers such as "container.blast_furnace" are not being translated yet

Implement some more windows

625817c

anvil, brewing stand, crafting table (still no crafting yet), shulker box

Merge branch 'master' into inventory

659d52d

Fix block ids

4620560

Retloldin approved these changes Dec 25, 2019

View reviewed changes

FrostNovaHD approved these changes Dec 27, 2019

View reviewed changes

Redned235 mentioned this pull request Jan 6, 2020

enchantment wont show on bedrock but will on java #133

Closed

Khushashi mentioned this pull request Jan 28, 2020

Bedrock players can't see items on Java players' hands #145

Closed

AJ-Ferguson added 3 commits January 30, 2020 12:08

Merge remote-tracking branch 'remotes/upstream/master' into inventory

5e5aeed

Some refactoring and bug fixes

1a9aa42

Still much to do. Inventory desyncing when crafting will be fixed soon.

Bump OpenNBT lib to 1.4-SNAPSHOT

3d61b3c

This fixes the NPE when sending an ItemStack with a null NBT tag. This also fixes some item movement bugs on pure vanilla servers.

Daisreich approved these changes Feb 2, 2020

View reviewed changes

Khushashi mentioned this pull request Feb 5, 2020

Players cannot eat #154

Closed

fierceeo approved these changes Feb 6, 2020

View reviewed changes

AJ-Ferguson added 2 commits February 12, 2020 21:58

Merge remote-tracking branch 'remotes/upstream/master' into inventory

b1a0ed3

# Conflicts: # connector/src/main/java/org/geysermc/connector/network/translators/TranslatorsInit.java # connector/src/main/java/org/geysermc/connector/utils/Toolbox.java

Fix Block IDs

bf1835e

Quick fix. Might have a different method for getting block IDs in the future

jackson-57 mentioned this pull request Feb 26, 2020

Add GUI support #184

Closed

AJ-Ferguson added 2 commits February 25, 2020 22:12

Merge remote-tracking branch 'remotes/upstream/master' into inventory

bc3992f

# Conflicts: # connector/src/main/java/org/geysermc/connector/network/translators/TranslatorsInit.java # connector/src/main/java/org/geysermc/connector/network/translators/inventory/updater/ChestInventoryUpdater.java

Fix compile errors

bfca25b

Redned235 changed the base branch from master to inventory February 29, 2020 19:28

Redned235 merged commit 964663f into GeyserMC:inventory Feb 29, 2020

Redned235 mentioned this pull request Mar 22, 2020

remaining inventory bugs #212

Closed

AJ-Ferguson deleted the inventory branch April 12, 2020 18:04

Hellohi3654 added a commit to HelloGeyser/Geyser that referenced this pull request Sep 20, 2020

Merge pull request GeyserMC#67 from Hellohi3654/master

f58914a

Update Master

Leahcimkrob mentioned this pull request Nov 9, 2022

Playstation-gamers has lags #3391

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inventory Transactions (Work in Progress) #67

Inventory Transactions (Work in Progress) #67

AJ-Ferguson commented Oct 20, 2019 •

edited by Redned235

FrostNovaHD commented Oct 21, 2019

Flonja commented Oct 21, 2019

FrostNovaHD commented Oct 21, 2019

FrostNovaHD commented Oct 22, 2019 •

edited

FrostNovaHD commented Oct 22, 2019

AJ-Ferguson commented Oct 22, 2019 •

edited

EOT3000 commented Oct 22, 2019

EOT3000 commented Oct 23, 2019 •

edited

FrostNovaHD commented Oct 23, 2019 •

edited

FrostNovaHD commented Oct 23, 2019

FrostNovaHD commented Oct 23, 2019

FrostNovaHD commented Oct 23, 2019

Kasjuhh commented Oct 29, 2019

Kasjuhh commented Oct 29, 2019 •

edited

ghost commented Jan 3, 2020

Encritary commented Jan 8, 2020

AJ-Ferguson commented Jan 8, 2020

FrostNovaHD commented Jan 8, 2020

Pecacheu commented Jan 22, 2020 •

edited

Daisreich left a comment

FrostNovaHD commented Mar 23, 2020

FrostNovaHD commented Mar 23, 2020

Inventory Transactions (Work in Progress) #67

Inventory Transactions (Work in Progress) #67

Conversation

AJ-Ferguson commented Oct 20, 2019 • edited by Redned235

FrostNovaHD commented Oct 21, 2019

Flonja commented Oct 21, 2019

FrostNovaHD commented Oct 21, 2019

FrostNovaHD commented Oct 22, 2019 • edited

FrostNovaHD commented Oct 22, 2019

AJ-Ferguson commented Oct 22, 2019 • edited

EOT3000 commented Oct 22, 2019

EOT3000 commented Oct 23, 2019 • edited

FrostNovaHD commented Oct 23, 2019 • edited

FrostNovaHD commented Oct 23, 2019

FrostNovaHD commented Oct 23, 2019

FrostNovaHD commented Oct 23, 2019

Kasjuhh commented Oct 29, 2019

Kasjuhh commented Oct 29, 2019 • edited

ghost commented Jan 3, 2020

Encritary commented Jan 8, 2020

AJ-Ferguson commented Jan 8, 2020

FrostNovaHD commented Jan 8, 2020

Pecacheu commented Jan 22, 2020 • edited

Daisreich left a comment

Choose a reason for hiding this comment

FrostNovaHD commented Mar 23, 2020

FrostNovaHD commented Mar 23, 2020

AJ-Ferguson commented Oct 20, 2019 •

edited by Redned235

FrostNovaHD commented Oct 22, 2019 •

edited

AJ-Ferguson commented Oct 22, 2019 •

edited

EOT3000 commented Oct 23, 2019 •

edited

FrostNovaHD commented Oct 23, 2019 •

edited

Kasjuhh commented Oct 29, 2019 •

edited

Pecacheu commented Jan 22, 2020 •

edited