Custom skull block support #683

BrandonKaim · 2020-05-28T22:19:34Z

Adds custom skulls through fake player entities! Works on player spawn and when the block is placed! I added a config option to enable it (its disabled by default to prevent lag from users who don't want them)

TODO: - Add to config as a setting - Spawn skulls on chunk load and not only on placement - Cleanup - Document more

Spawns fake skulls on spawn and added a config options for those who do not want skulls. This is set to false by default just incase they don't want added lag.

...ava/org/geysermc/connector/network/translators/world/block/entity/CustomSkullTranslator.java

...va/org/geysermc/connector/network/translators/java/world/JavaUpdateTileEntityTranslator.java

connector/src/main/java/org/geysermc/connector/utils/ChunkUtils.java

connector/src/main/java/org/geysermc/connector/utils/SkinProvider.java

connector/src/main/resources/config.yml

Changes how rotation is calculated, adds null checks for if the skull isn't an actual player skull, and optimizes it so there are no useless packets or variables being set.

…hing

Custom skull code simplifying

...rg/geysermc/connector/network/translators/world/block/entity/SkullBlockEntityTranslator.java

Now removes skulls on chunk unload for performance and fixed small things.

Camotoy

Looking really good!

bootstrap/bukkit/src/main/java/org/geysermc/platform/bukkit/GeyserBukkitConfiguration.java

...rg/geysermc/connector/network/translators/world/block/entity/SkullBlockEntityTranslator.java

connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java

Removed setter and made naming convention like the other caches

...rap/bungeecord/src/main/java/org/geysermc/platform/bungeecord/GeyserBungeeConfiguration.java

bootstrap/sponge/src/main/java/org/geysermc/platform/sponge/GeyserSpongeConfiguration.java

connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java

...rg/geysermc/connector/network/translators/world/block/entity/SkullBlockEntityTranslator.java

connector/src/main/java/org/geysermc/connector/utils/ChunkUtils.java

connector/src/main/java/org/geysermc/connector/utils/SkinProvider.java

Fix naming conventions, change using java ids to just using the blockstate for wall directions, and a few other things.

rtm516 · 2020-05-30T14:13:39Z

Will this work with skulls on armour stands?

No, not from what I understand anyway. Maybe possible in the future but out of scope I think for this PR

Redned235 · 2020-05-30T22:27:17Z

connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java

@@ -104,6 +107,7 @@
    private InventoryCache inventoryCache;
    private ScoreboardCache scoreboardCache;
    private WindowCache windowCache;
+    private Map<Position, Long> skullCache = new HashMap<>();


Replace this with an Object2LongMap.

Redned235 · 2020-05-30T22:28:15Z

...rg/geysermc/connector/network/translators/world/block/entity/SkullBlockEntityTranslator.java

+        if (BlockStateValues.getSkullRotation(blockState) == -1) {
+            y += 0.25f;
+            switch (BlockStateValues.getWallSkullDirection().get(blockState)) {
+                case "north]":


Is there any way you could exclude this bracket here from the switch statement?

Camotoy · 2020-12-01T22:57:07Z

@Hellohi3654 fixed in the latest commit and silenced to debug mode.

…om-skulls

Since we aren't using it yet anyway.

RedSmarty · 2020-12-04T05:39:55Z

Hello, i would love to see this thing in action, but i guess u still cant find a way to get those heads working in inventory. Hmm, correct me if i am wrong. I guess i found a way, i know its not good and is heavy, but
What if u just cache a lot of player heads and automatically create a pack for those heads?
Iirc player head png's are not that heavy.
And if u can use base64, it would be more lighter, maybe u will not want to use this,
But thats only my opinion. If u thought of another way, then pls let me know.

Camotoy · 2020-12-04T05:41:49Z

We could do this for the player's own head, but otherwise, it's not really worth it. Especially when using standalone, we can't guarantee what player heads the player will be using in their inventory.

RedSmarty · 2020-12-04T05:44:00Z

So there's no real way to distinguish between them? I wanted this bcoz many plugins rely on heads like slimefun, companions, bag of gold, etc. Maybe allow owners to package some important heads?
Edit :- just recalled, companion needs not to be in inventories lol

jackson-57 · 2020-12-04T07:22:21Z

I think it would be helpful for server owners to be able to specify a list of player heads to add in a pack. For example, if a server owner is running Slimefun, they could use a list of Slimefun player heads. I expanded on this a few weeks ago over in the #development channel in the Discord.

RedSmarty · 2020-12-04T09:11:03Z

Thats what i am saying, but i think i cant explain it correctly.

zimzaza4 · 2020-12-04T14:40:22Z

When I use Slimefun, all its head names become "CS-CoreLib's head"

Stale

MissGamerz · 2021-11-10T00:20:27Z

maybe intergrating into head database plugin to make this possible?

BobtheBob123456 · 2022-07-18T22:41:49Z

Hi Guys,
First of, has this been implemented yet? Secondly, doesn't bedrock already support custom skulls (https://primagames.com/tips/can-you-get-player-heads-in-minecraft-bedrock-edition-answered).

And if it doesn't, could you use a resource pack/addon like the one seen here (https://foxynotail.com/add-ons/player-heads/).

That is All

Kas-tle · 2022-07-18T22:49:35Z

Merged means that the proposed changes were incorporated into Geyser, so yes this has been implemented.

The article you linked is complete misinformation and is likely just trawling for search engine clicks. Bedrock edition does not have native support for arbitrarily skinned player heads.

A resource pack would not solve the issue as we need to be able to dynamically spawn in any player head. A resource pack would require that we know what heads are going to be spawned in beforehand. In the future, please use the Discord for questions like this rather than posting on a stale pull request.

Hellohi3654 · 2022-07-18T22:52:48Z

Hi Guys, First of, has this been implemented yet? Secondly, doesn't bedrock already support custom skulls (https://primagames.com/tips/can-you-get-player-heads-in-minecraft-bedrock-edition-answered).

And if it doesn't, could you use a resource pack/addon like the one seen here (https://foxynotail.com/add-ons/player-heads/).

That is All

Bedrock currently doesn't support custom skulls
At least it didn't when this pull request was merged

Geyser spawns a player in the place of custom skulls and removes the body of the player model just leaving the head which gives the illusion of custom skulls for bedrock players

Only problem with doing it is that if you have a tonne of custom skulls then it can cause a lot of lag for bedrock players

You could use a resource pack like the foxy no tail one but then you couldn't have custom player skulls as you would have to have every player skin possible in the resource pack or make the player leave and rejoin to download a resource pack everytime a new player skull is created

Besides that I think the foxy no tail resource pack just creates custom mobs to recreate all the mob skulls so this probably won't solve the lag problem

OakLoaf · 2023-01-06T23:04:15Z

Will this ever work for skulls on armour stands? I am not particularly worried about placed ones so ideally would be under a different config option

Camotoy · 2023-01-07T00:40:16Z

I think that can now be implemented, seeing as one of our developers implemented some performance improvements for skulls. It's just a matter of somebody getting around to it.

Kas-tle · 2023-01-07T01:02:49Z

When I do the block mappings PR that is on top of the block and skull system so it would be included with that, but I imagine it will be a while even once the PR is open since custom blocks are a fairly major change and will require testing (and therefore take a while).

BrandonKaim added 3 commits May 28, 2020 11:57

Implementation of Custom Skull

34f5142

TODO: - Add to config as a setting - Spawn skulls on chunk load and not only on placement - Cleanup - Document more

Merge remote-tracking branch 'upstream/master' into custom-skulls

bd1d40d

Skulls 2: Electric Boogaloo

ca6d331

Spawns fake skulls on spawn and added a config options for those who do not want skulls. This is set to false by default just incase they don't want added lag.

rtm516 requested changes May 28, 2020

View reviewed changes

Camotoy requested changes May 28, 2020

View reviewed changes

Fixes

97e9de2

Changes how rotation is calculated, adds null checks for if the skull isn't an actual player skull, and optimizes it so there are no useless packets or variables being set.

BrandonKaim requested review from rtm516 and Camotoy May 29, 2020 01:21

Camotoy and others added 5 commits May 28, 2020 23:40

Update custom skulls to reuse existing code and not rely on chunk cac…

af1ac37

…hing

Small fixes

fe355f3

Rename SkullBlockEntityTranslator functions to match code style

9099009

Merge pull request #2 from DoctorMacc/custom-skulls

d8798eb

Custom skull code simplifying

No longer uses chunk caching!

c43747f

rtm516 requested changes May 29, 2020

View reviewed changes

...rg/geysermc/connector/network/translators/world/block/entity/SkullBlockEntityTranslator.java Outdated Show resolved Hide resolved

...rg/geysermc/connector/network/translators/world/block/entity/SkullBlockEntityTranslator.java Outdated Show resolved Hide resolved

Add removal of skulls on chunk unload and fix small things

8fc875a

Now removes skulls on chunk unload for performance and fixed small things.

rtm516 approved these changes May 29, 2020

View reviewed changes

Camotoy requested changes May 29, 2020

View reviewed changes

bootstrap/bukkit/src/main/java/org/geysermc/platform/bukkit/GeyserBukkitConfiguration.java Outdated Show resolved Hide resolved

...rg/geysermc/connector/network/translators/world/block/entity/SkullBlockEntityTranslator.java Outdated Show resolved Hide resolved

rtm516 added PR: Feature When a PR implements a new feature Work in Progress The issue is currently being worked on. labels May 29, 2020

Set skull cache to per session

22c2ccc

rtm516 requested changes May 29, 2020

View reviewed changes

connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java Outdated Show resolved Hide resolved

BrandonKaim added 2 commits May 29, 2020 19:34

fixedWEIRD_NAMING

e015d58

Removed Setter

fe907cd

Removed setter and made naming convention like the other caches

BrandonKaim requested review from rtm516 and Camotoy May 29, 2020 23:38

Redned235 approved these changes May 30, 2020

View reviewed changes

BrandonKaim added 2 commits May 29, 2020 22:17

Small changes

c40d65c

Fix naming conventions, change using java ids to just using the blockstate for wall directions, and a few other things.

Fix capitalization

8d5777c

Redned235 previously requested changes May 30, 2020

View reviewed changes

Merge branch 'master' of https://github.com/GeyserMC/Geyser into cust…

7245ff6

…om-skulls

j5155 mentioned this pull request Dec 2, 2020

Player heads show up as Steve heads in the bedrock edition of Minecraft #1616

Closed

rtm516 linked an issue Dec 2, 2020 that may be closed by this pull request

Player heads show up as Steve heads in the bedrock edition of Minecraft #1616

Closed

Camotoy added 2 commits December 3, 2020 19:54

Merge branch 'master' of https://github.com/GeyserMC/Geyser into cust…

313126b

…om-skulls

Clean up and remove schedule entirely

8a23d99

Since we aren't using it yet anyway.

Camotoy approved these changes Dec 4, 2020

View reviewed changes

Fix documentation

4b84584

Camotoy and others added 2 commits December 4, 2020 16:37

Fix wrong method being called

61a73e8

Use get instead of getOrDefault

8a6b003

Tim203 approved these changes Dec 4, 2020

View reviewed changes

Update config to set default value

8998840

Camotoy merged commit 2c0f3ec into GeyserMC:master Dec 4, 2020

Aryan2-1 mentioned this pull request Jul 18, 2021

Java custom heads shows as steve #2393

Closed

rockyhawk64 mentioned this pull request Oct 5, 2021

Intigration of Geyser and Flootgate rockyhawk64/CommandPanels#168

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom skull block support #683

Custom skull block support #683

BrandonKaim commented May 28, 2020

Camotoy left a comment

rtm516 commented May 30, 2020

Redned235 May 30, 2020

Redned235 May 30, 2020

Camotoy commented Dec 1, 2020

RedSmarty commented Dec 4, 2020

Camotoy commented Dec 4, 2020

RedSmarty commented Dec 4, 2020 •

edited

Loading

jackson-57 commented Dec 4, 2020

RedSmarty commented Dec 4, 2020

zimzaza4 commented Dec 4, 2020

MissGamerz commented Nov 10, 2021

BobtheBob123456 commented Jul 18, 2022

Kas-tle commented Jul 18, 2022 •

edited

Loading

Hellohi3654 commented Jul 18, 2022

OakLoaf commented Jan 6, 2023

Camotoy commented Jan 7, 2023

Kas-tle commented Jan 7, 2023

Custom skull block support #683

Custom skull block support #683

Conversation

BrandonKaim commented May 28, 2020

Camotoy left a comment

Choose a reason for hiding this comment

rtm516 commented May 30, 2020

Redned235 May 30, 2020

Choose a reason for hiding this comment

Redned235 May 30, 2020

Choose a reason for hiding this comment

Camotoy commented Dec 1, 2020

RedSmarty commented Dec 4, 2020

Camotoy commented Dec 4, 2020

RedSmarty commented Dec 4, 2020 • edited Loading

jackson-57 commented Dec 4, 2020

RedSmarty commented Dec 4, 2020

zimzaza4 commented Dec 4, 2020

MissGamerz commented Nov 10, 2021

BobtheBob123456 commented Jul 18, 2022

Kas-tle commented Jul 18, 2022 • edited Loading

Hellohi3654 commented Jul 18, 2022

OakLoaf commented Jan 6, 2023

Camotoy commented Jan 7, 2023

Kas-tle commented Jan 7, 2023

RedSmarty commented Dec 4, 2020 •

edited

Loading

Kas-tle commented Jul 18, 2022 •

edited

Loading