Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "The {{ site.data.versions.java }} field in faq.yml does not take effect" #186

Closed
wants to merge 21 commits into from

Conversation

mcchampions
Copy link
Contributor

@mcchampions mcchampions commented Aug 12, 2023

Fix #185 .
Use JavaScript.
This is the least I can think of to change the way.
Also, the lower indentation has been modified by the way.
Original:

image

Current:
image

@mcchampions mcchampions requested review from a team as code owners August 12, 2023 16:02
@mcchampions mcchampions changed the title Fix "The {{ site.data.versions.java }} field in faq.yml does not take effect" and djust the indentation Fix "The {{ site.data.versions.java }} field in faq.yml does not take effect" Sep 16, 2023
Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the formatting changes, they're not really needed - as for the solution itself, it seems fairly... temporary; but with the upcoming move to Docusaurus (#198) this wouldn't be long term anyways.

@onebeastchris onebeastchris added the content PRs modifying wiki content label Nov 2, 2023
@Chew Chew mentioned this pull request Jan 28, 2024
8 tasks
@Chew
Copy link
Member

Chew commented Jun 27, 2024

Hi there! We've decided to switch the wiki software we're using, so this fix is no longer necessary. Unfortunately, I'll have to close this for now. Thank you for your work on this, and we hope to have you contribute again soon!

@Chew Chew closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content PRs modifying wiki content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The {{ site.data.versions.java }} field in faq.yml does not take effect
3 participants