-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand contact model #25
Comments
@tmyersdn, could you spend a couple more words about the above? email address, that's clear, but a flag for receipt of seed list, how would you use this? |
actually, "how would you use that", the same question applies to email address, why would you need a separate field when you have a multiline description field? |
Hi Mario, I will reply to the questions above under new issues, Can you help me understand: what is a "contact", is this a source from the accessions table? Or is it something else? |
in terms of the Bauble/Ghini database structure, a "Contact" is not a |
from a user viewpoint, is this seen as the "source details" window that opens when you click on "new" source in the accessions source tab? |
yes, that is it. you can get to the same window by following Insert→Contact from the main menu. |
ah, okay, I am on Bauble 1.0.55, that option is not there. Yes, I would like to move to Ghini, I will do that as soon as time permits this week. |
I think I will commit changes into |
just a note on ITF2: Donor. - I would feel pretty uncomfortable including email addresses or peoples names in Donor for export to BGCI. |
I see your concern; what about a private flag so you can inform the reporting script not to include the donor? # ITF2 - E6 - Donor
name = Column(Unicode(75), unique=True)
# extra description, not included in E6
description = Column(UnicodeText)
# ITF2 - E5 - Donor Type Flag
source_type = Column(types.Enum(values=[i[0] for i in source_type_values],
translations=dict(source_type_values)),
default=None) but anyway you decide what and if to export, not the software. the software just helps you do that. |
That sounds good, but note, this is probably a minor concern for BGCI reports. At present BGCI just asks for taxonomy fields not all the extended data fields like donor. But it probably makes sense to include a private flag just to because privacy is an issue. Also, I think having an separate email field will mean that email addresses are kept out of the "donor" description field. |
…a try-catch block, so we do not end up with a non-responsive dialog box. related to Ghini#25.
urgent patch. Ghini#25.
from @tmyersdn Bauble/bauble.classic#277
The text was updated successfully, but these errors were encountered: