Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand contact model #25

Closed
mfrasca opened this issue Jan 25, 2016 · 11 comments
Closed

expand contact model #25

mfrasca opened this issue Jan 25, 2016 · 11 comments
Labels
ghini-3.1 rfc ask users about it ux ux bug

Comments

@mfrasca
Copy link
Member

mfrasca commented Jan 25, 2016

(c) contacts could include a flag for receipt of seed list and email address to use for the seed list.

from @tmyersdn Bauble/bauble.classic#277

@mfrasca mfrasca added this to the ghini-1.1.1 milestone Jan 26, 2016
@mfrasca
Copy link
Member Author

mfrasca commented Jan 26, 2016

@tmyersdn, could you spend a couple more words about the above?

email address, that's clear, but a flag for receipt of seed list, how would you use this?

@mfrasca mfrasca added rfc ask users about it ux ux bug labels Jan 26, 2016
@mfrasca
Copy link
Member Author

mfrasca commented Jan 26, 2016

actually, "how would you use that", the same question applies to email address, why would you need a separate field when you have a multiline description field?
just asking, and trying to avoid work that is not necessary.

@tmyersdn
Copy link

Hi Mario, I will reply to the questions above under new issues,

Can you help me understand: what is a "contact", is this a source from the accessions table? Or is it something else?

@mfrasca
Copy link
Member Author

mfrasca commented Jan 26, 2016

in terms of the Bauble/Ghini database structure, a "Contact" is not a Source, it's a SourceDetail.
in ITF2 terms, it's a Donor

@tmyersdn
Copy link

from a user viewpoint, is this seen as the "source details" window that opens when you click on "new" source in the accessions source tab?

@mfrasca
Copy link
Member Author

mfrasca commented Jan 26, 2016

yes, that is it. you can get to the same window by following Insert→Contact from the main menu.

@tmyersdn
Copy link

ah, okay, I am on Bauble 1.0.55, that option is not there. Yes, I would like to move to Ghini, I will do that as soon as time permits this week.

@mfrasca
Copy link
Member Author

mfrasca commented Jan 26, 2016

I think I will commit changes into bauble-1.0 as well, and anyhow, 1.0.56 is not out yet so you would not find it in ghini-1.0 either.

@tmyersdn
Copy link

just a note on ITF2: Donor. - I would feel pretty uncomfortable including email addresses or peoples names in Donor for export to BGCI.

@mfrasca
Copy link
Member Author

mfrasca commented Jan 26, 2016

I see your concern; what about a private flag so you can inform the reporting script not to include the donor?
we already have this in accessions, not that I know of any reporting script acknowledging it.

    # ITF2 - E6 - Donor
    name = Column(Unicode(75), unique=True)
    # extra description, not included in E6
    description = Column(UnicodeText)
    # ITF2 - E5 - Donor Type Flag
    source_type = Column(types.Enum(values=[i[0] for i in source_type_values],
                                    translations=dict(source_type_values)),
                         default=None)

but anyway you decide what and if to export, not the software. the software just helps you do that.

@tmyersdn
Copy link

That sounds good, but note, this is probably a minor concern for BGCI reports. At present BGCI just asks for taxonomy fields not all the extended data fields like donor.

But it probably makes sense to include a private flag just to because privacy is an issue.

Also, I think having an separate email field will mean that email addresses are kept out of the "donor" description field.

RoDuth pushed a commit to RoDuth/ghini.desktop that referenced this issue Dec 30, 2017
RoDuth pushed a commit to RoDuth/ghini.desktop that referenced this issue Dec 30, 2017
…a try-catch block, so we do not end up with a non-responsive dialog box. related to Ghini#25.
RoDuth pushed a commit to RoDuth/ghini.desktop that referenced this issue Dec 30, 2017
RoDuth pushed a commit to RoDuth/ghini.desktop that referenced this issue Dec 30, 2017
@mfrasca mfrasca removed this from the ghini-1.1.1 milestone May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghini-3.1 rfc ask users about it ux ux bug
Projects
None yet
Development

No branches or pull requests

2 participants