Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make nsis script use local plugins #357

Merged
merged 1 commit into from May 25, 2018

Conversation

RoDuth
Copy link
Contributor

@RoDuth RoDuth commented May 24, 2018

@mfrasca mfrasca merged commit 8333d61 into Ghini:ghini-1.0-dev May 25, 2018
@mfrasca
Copy link
Member

mfrasca commented May 25, 2018

this doesn't yet address forcibly installing in virtual environment, in case corresponding egg is available as a system-site-package.

@RoDuth
Copy link
Contributor Author

RoDuth commented May 25, 2018

from memory you, as I had done at one point, had installed py2exe from the sourceforge installer. These only work on the global install and hence you would have had to install all the dependencies globally also, as I had done also. I feel this does not seem like a common scenario if someone is following the instructions and using standard practices (virtual environments). Could try using this I guess but that seems like it would be a pain for all subsequent runs of the script. I have mentioned this approach in the documentation on the 'py2exe will not work with eggs' section. I think if someone was looking to troubleshoot this rare issue that should be enough. Or maybe another dot point mentioning the possibility of globally installed eggs. I much prefer to keep the script simple as it is only there for convenience.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 65.825% when pulling 1bdd818 on RoDuth:ghini-1.0-dev into fdf95d4 on Ghini:ghini-1.0-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants