New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --vo=libmpv not being set when empty #67

Merged

GhostNaN merged 1 commit into GhostNaN:master from leaty:master

Apr 19, 2024

Contributor

leaty commented Apr 19, 2024 •

edited

Fixes #64 and #68.

It appears vo in mpv 0.38.0 no longer defaults to libmpv in this context, this forces libmpv to be set when empty.


          Fix --vo=libmpv not being set when empty

5351b3b

Owner

GhostNaN commented Apr 19, 2024

Good work!
I should of looked more closely at the new API changes to mpv 0.38.
https://github.com/mpv-player/mpv/blob/master/DOCS/client-api-changes.rst#api-changes
"remove libmpv as the default VO and move it to the bottom of the auto-probing order"

So yes, forcing the VO to "libmpv" even when it's empty fixes the issue without warning the user.

I might have to update the release now with this breaking bug.

GhostNaN merged commit 8fe75d8 into GhostNaN:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment