Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for the new info_pac_buffers and the ability to request… #105

Merged
merged 2 commits into from Dec 13, 2021

Conversation

0xe7
Copy link
Contributor

@0xe7 0xe7 commented Nov 19, 2021

… initial TGTs without a PAC

New PAC_INFO_BUFFERs are now parsed and output by describe:

    Attributes             :
      Attributes           : 0200000001000000
    Requestor              :
      RequestorSID         : S-1-5-21-652637156-682571310-46925969-1103

The Attributes section seems to be a static value for now so not sure exactly how to parse it properly, the raw bytes are output.

@0xe7
Copy link
Contributor Author

0xe7 commented Dec 9, 2021

The Attributes section is now created and parsed correctly:

    Attributes             :
      AttributeLength      : 2
      AttributeFlags       : (1) PAC_WAS_REQUESTED

Copy link
Contributor

@CCob CCob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We definitely need to look at how arguments are filtered down to various functions at some point. A lot of the changes all relate to modifying function prototypes to pass in new arguments.

@HarmJ0y
Copy link
Member

HarmJ0y commented Dec 13, 2021

Awesome stuff, sorry for the delay in landing!

@HarmJ0y HarmJ0y merged commit aa4f6ea into master Dec 13, 2021
@HarmJ0y HarmJ0y deleted the pac branch December 13, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants