Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphans with compose up #210

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Remove orphans with compose up #210

merged 2 commits into from
Sep 7, 2018

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented Sep 6, 2018

Purpose

Revisit https://feathub.com/GhostWriters/DockSTARTer/+14 and actually remove orphans using the build in option with compose. The prune option that was considered to resolve the request does not actually remove orphans, it only cleans up unused objects after the container is stopped. Without using the build in remove orphans option the container is left running.

Approach

Add the remove orphans option to compose up. This will Stop and remove a container that is no longer considered part of the stack. The existing prune option will clean up unused resources such as the image that the container used (this is not automatically removed when an orphan container is removed).

Learning

https://docs.docker.com/compose/reference/up/

Requirements

@nemchik nemchik added the enhancement New feature or request label Sep 6, 2018
@nemchik nemchik added this to the 18.09 milestone Sep 6, 2018
@nemchik nemchik self-assigned this Sep 6, 2018
@nemchik nemchik added this to In progress in Back End via automation Sep 6, 2018
@nemchik
Copy link
Member Author

nemchik commented Sep 6, 2018

Pinging @doowrednu as this request originally came from him on feathub and he may want to follow this PR for updates when it merges.

@nemchik nemchik merged commit 6811fd8 into master Sep 7, 2018
Back End automation moved this from In progress to Done Sep 7, 2018
@nemchik nemchik deleted the orphans branch September 7, 2018 10:20
@nemchik nemchik added the core Automatic label label Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Automatic label enhancement New feature or request
Projects
No open projects
Back End
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants