Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makemkv #565

Merged
merged 2 commits into from Feb 11, 2019
Merged

Makemkv #565

merged 2 commits into from Feb 11, 2019

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented Feb 11, 2019 •
edited

Purpose

This partially closes #340 which is a request for two different apps, the other will be handled separately.

Approach

Add the required files

Open Questions and Pre-Merge TODOs

  • Confirm full generator test succeeds

Learning

https://hub.docker.com/r/jlesage/makemkv

Requirements

@ghost ghost assigned nemchik Feb 11, 2019
@ghost ghost added the in progress label Feb 11, 2019
@nemchik nemchik added this to the 19.02 milestone Feb 11, 2019
@nemchik nemchik added this to In progress in Apps via automation Feb 11, 2019
@nemchik nemchik added the enhancement New feature or request label Feb 11, 2019
@nemchik nemchik merged commit 0eaead6 into master Feb 11, 2019
Apps automation moved this from In progress to Done Feb 11, 2019
@ghost ghost removed the in progress label Feb 11, 2019
@nemchik nemchik deleted the makemkv branch February 11, 2019 21:11
@nemchik nemchik added the apps Automatic label label Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nemchik nemchik

Labels
apps Automatic label enhancement New feature or request
Projects
No open projects
Apps
  
Done
Milestone
19.02
Development

Successfully merging this pull request may close these issues.

MakeMKV/Handbrake
1 participant
@nemchik