Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
GhostofGoes committed Oct 12, 2023
1 parent d43446d commit 7b58939
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions docs/TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
- [ ] rewrite strings to f-strings
- [ ] CLI: put "override" and other debugging-related arguments into a separate argparse argument group
- [ ] Split getmac.py into separate files for methods, utils, etc.
- [ ] Refactor how global variables are handled
- [ ] Remove all Python "Scripts" from the path, so they don't interfere with the commands we actually want (e.g. "ping"). Document this behavior!
- [ ] **Consolidate `ip6` argument into `ip` argument.**. Parse based on `::` character vs `.` character if `str` or via `.version == 4`/`.version == 6` for `ipaddress` objects.
- Combine `--ip` and `--ip6` CLI arguments into `--ip` output. this would make it *much* easier to test methods.
Expand All @@ -61,6 +62,7 @@
- Document these features in the README/docs, including the CLI arguments

## Enhancements/fixes/misc.
- [ ] Properly support WSL2
- [ ] move more logic out of `get_mac_address()` into individual methods:
- [ ] interface
- [ ] remote host
Expand Down
4 changes: 2 additions & 2 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ def test_cli_no_net():


def test_cli_override_port():
assert (
run_cmd([*BASE_CMD, "-v", "-dd", "-4", "127.0.0.1", "--override-port", "44444"])
assert run_cmd(
[*BASE_CMD, "-v", "-dd", "-4", "127.0.0.1", "--override-port", "44444"]
)


Expand Down

0 comments on commit 7b58939

Please sign in to comment.