Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terraform 0.12 support #42

Closed
lazouz opened this issue Jun 21, 2019 · 7 comments
Closed

Add terraform 0.12 support #42

lazouz opened this issue Jun 21, 2019 · 7 comments

Comments

@lazouz
Copy link

lazouz commented Jun 21, 2019

Hi,

Terraform 0.12 is out, and the grammar has changed a little bit.

see https://www.terraform.io/docs/configuration/syntax.html

It would be great to update this package accordingly !

@AndrewFarley
Copy link

+1 - 6 months later since creation we still need this

@Prophet32j
Copy link

+1

@cmur2
Copy link
Owner

cmur2 commented Feb 21, 2020

As I really wanted to get syntax highlighting for Terraform 0.12 features and did not want to wait any longer I hacked something together based on the current grammar (left old grammar, right new):

image (4)

To be able to use the new grammar now I forked this repository (as contributions from PRs are not getting merged in the last year) to https://github.com/cmur2/language-terraform-12 and created a new Atom package language-terraform-12:

apm uninstall language-terraform && apm install language-terraform-12

I would be more than happy to upstream my changes into this (the original) package that is soo useful if the maintainer wants to 🙂

Edit: upstreaming happened, see #46.

@GiantToast
Copy link
Collaborator

Hi @cmur2 I sent you an email about possibly taking over this repo. I haven't had the time in quite a while now to give this the attention it deserves and would love to find it a new home.

@lazouz
Copy link
Author

lazouz commented Apr 17, 2020

great !

@cmur2 cmur2 mentioned this issue Apr 18, 2020
@cmur2
Copy link
Owner

cmur2 commented Apr 18, 2020

For transparency: the maintainer changed now, see #46 for more details including next steps.

@cmur2
Copy link
Owner

cmur2 commented Apr 19, 2020

Closing since most important TF 0.12 syntax features done via 45a9b38 and 86289aa - there is certainly room for more, happy to accept contributions!

@cmur2 cmur2 closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants