Fixed broken alignment target and saving throw penalty effects for Unholy Blight #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, those labels are incorrect/misleading (I have already fixed them though ...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The problems were two-fold:
1.) Unholy Blight was only affecting NEUTRAL aligned characters. Good and Evil aligned were immune.
2.) The saving throw penalty was implemented as a mod% operation, rather than an increment. This generally resulted in giving the targets a saving throw bonus of -10 across the board instead of a penalty of +2.
In addition, the operation for Creature type: ALIGNMENT bit_uneq MASK_GOOD [0x1] (35) appears to be broken in BGEE. I don't know if this is a hard-coded bug or what, but it causes the spell to affect Evil aligned as well as Good. I solved this issue by creating two different Immunity to resource and message (324) entries, for Evil and Neutral. Holy Smite does not have any issues.