Update Russian translation, tp2 file and fix bug in d file #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tp2 file was fixed to copy characters sounds (using weidu), so they have sounds while creating party Fix bug of not creating 63GenTS item in one branch (in d file).
|
Looks mostly fine to me (it should be 3 commits), but I don't have commit access. What does the conversion from OGG to WAV? |
|
The conversion was before. I just copied wav files using weidu (it was the commented code to do the same using bat files), so the sounds can be played during characters creation. You are probably right, it should be three commits, but idk how to change it now. |
|
Ah, you're right, it's just a few lines above (HANDLE_AUDIO). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Russian translation
tp2 file was fixed to copy characters sounds (using weidu), so they have sounds while creating party
Fix bug of not creating 63GenTS item in one branch (in d file).