New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arcane level 1 fixes #41
Arcane level 1 fixes #41
Conversation
All of the files in the commit have a single quote at the end of their filenames, so this is being treated as introducing new files rather than changing the existing ones. |
Grrr, a dangling ' in the WeiDU code. Fixing asap. |
I will do a squash before committing to keep the git history clean. |
Only tangentially related to your fixes, but I think SR should consider making it so that the Charm series of spells results in a non-hostile reaction once the charm effect has ended for BG1's sake: lots of Charm-specific dialogue in that game that you cannot realistically access when the spell irreversibly and unavoidably always causes hostility to the charmed NPC. |
I will keep that in mind. |
I still think it's worth discussing whether/how to make Charm more like a localized Friends effect, than "Domination at 1st level." I know we never found a solution that Demi liked and/or that would play nice with SCS... but I hate this spell as it exists in this engine, and I still hope to find a valid modification of it. Maybe drastically reduce the duration. Heck, maybe it should just be replaced altogether. Give Friends the Charm effect to get that BG1 dialogue. |
Agreed. I would suggest changing the charm type to 0 of the charm opcodes in the spells Charm Person (wizard, level 1) and maybe Charm Person or Mammal (cleric, level 2). This is the easiest and most straightforward implementation -- if I am reading the IESDP correctly. Any cons? Since this is a functional change, I will open an RFC. |
Deferring the charm stuff to a new PR and merging this. |
Arcane Level 1 spell fixes.