Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save images in Reports -> Template Builder -> Signature Box #1376

Closed
tr-j opened this issue Jul 2, 2021 · 7 comments
Closed

Cannot save images in Reports -> Template Builder -> Signature Box #1376

tr-j opened this issue Jul 2, 2021 · 7 comments
Labels

Comments

@tr-j
Copy link

tr-j commented Jul 2, 2021

Describe the bug
I went in to modify an existing report and cannot update the signature. The record saves successfully, but the file input box remains blank.

To Reproduce

  1. Using Gibbon 22.0, go to Reports / Template Builder / Signature Box
  2. Select an image
  3. Save
  4. See error

Expected behavior
This should update the image as it has before.

Your System

  • Gibbon version [e.g. v22.0.00]
  • PHP 7.3 and PHP 8.0

Additional context
The error log reports only this issue (in modules/Reports/error_log):
PHP Fatal error: Uncaught League\Container\Exception\NotFoundException: Alias (Gibbon\Module\Reports\Domain\ReportTemplateGateway) is not being managed by the container or delegates in /home/gibbon/public_html/vendor/league/container/src/Container.php:188
Stack trace:
#0 /home/gibbon/public_html/modules/Reports/templates_manage_section_editProcess.php(38): League\Container\Container->get('Gibbon\Module\R...')
#1 {main}
thrown in /home/gibbon/public_html/vendor/league/container/src/Container.php on line 188

@SKuipers
Copy link
Member

SKuipers commented Jul 4, 2021

Hmm, something odd is definitly going on. Are you running a fresh install of v22, or an upgraded version? If upgraded, I wonder if not all files properly uploaded when updating, as a container NotFoundException sounds pretty serious, and would affect other areas of the system too.

@tr-j
Copy link
Author

tr-j commented Jul 4, 2021

Hi, it is upgraded, not a fresh install. We have only upgraded in the past week. It's possible we'll encounter other issues, but mostly everything else is working so far. The upgrade went smoothly. Everything that I can see within Gibbon says it's fine, such as this:

Gibbon Version: v22.0.00 OK
PHP Version: 8.0.7 OK
MySQL Version: 10.3.30 OK

The system check reports no issues. Is there another component that uses similar functionality that I can test to see if the problem can be narrowed down?

@yookoala yookoala added the bug label Aug 25, 2021
@KelvinMW
Copy link

same issue, I cannot upload a logo in:
reports>> template builder ...we're in the process of producing reports and as I was customizing the reports as usual(after upgrade from v21 and everything seems to be running smoothly).
can't upload logo to new template

all other aspects seems to be running smoothly.

@yookoala
Copy link
Member

@KelvinMW: Do you see any relevant error message in the error_log file? If so, please post the full error message here. Thanks.

@KelvinMW
Copy link

unfortunately the error is not being captured in the error_log file.. I can only trace errors captured from different past server errors.
but the URL returns success:
/modules/Reports/templates_manage_section_edit.php&gibbonReportTemplateID=0000000002&gibbonReportTemplateSectionID=0000000003&search=&return=success0&editID=1
no error is thrown

@SKuipers
Copy link
Member

Hi @KelvinMW and @tr-j, thanks for flagging this issue. I've had a chance to look into it and it appears there is indeed a bug, related to the way v22 changed the custom fields functionality. I've fixed the bug here in v23, you can apply the same patch to your system by copying the file over or making the same changes.

It looks like the reason it wasn't generating an error message is related to the way browsers handle file uploads, there was a syntax mismatch in the name of the file input, so the $_FILES array was silently failing to be submitted from the browser 😬

@KelvinMW
Copy link

Thank you so much... this was kinder an emergency because one of our sections it was their first time trying to generate reports so a did a temporary solution by trying to upload manually and directly from the DB( copying paths and files to necessary locations and uploading those images in the uploads folder ...lot's of work but it was a temporary solution to just make sure things are running smoothly..

A BIG THANK YOU FOR THE FIX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants