Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hex viewer #357

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chrisgleissner
Copy link

@chrisgleissner chrisgleissner commented Jul 4, 2023

Features

Design Notes

  • The decision about which view to use for opening a file was deliberately left to the user. There may be legit use cases to open a text file in hex view, and vice versa.
  • The firmware resulting from this PR was successfully flashed to a 64 Ultimate Elite, revision 1.4. All testing was done on this machine.
  • The offset rolls over from FFFF to 0000 if browsing a file larger than 64KiB. This should be OK as it mostly concerns browsing D64 and similar large files.

Examples

New "Hex View" entry in context-sensitive menu:
image

New "Hex View":
image

Same file opened via existing "View" which was left unchanged. In this example, byte 0x00 at offset 0x3b terminates the string rendering:
image

New "Hex View" using sample file containg contiguous sequence of numbers from 1 through 255:
image

@chrisgleissner
Copy link
Author

The branch feature/320-hex of this PR has been merged into the new branch chrisgleissner-feature/320-hex and the merge conflicts have been resolved there. Pending on that new branch are adjustments to the build files for the non-U64 builds which @GideonZ will take care of as discussed - many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant