Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling newer modules #527

Merged
merged 1 commit into from
May 13, 2024
Merged

Enabling newer modules #527

merged 1 commit into from
May 13, 2024

Conversation

csjones
Copy link
Contributor

@csjones csjones commented May 13, 2024

馃

Copy link

what-the-diff bot commented May 13, 2024

PR Summary

  • New module activation option in Package Configuration
    A definition for "ENABLE_MODULE_ELLSWIFT" was added in Package.swift. This provides an option to activate a new module which could extend functionality.

  • New Files for Enhancing Existing Functionality
    New files namely secp256k1_ellswift.h and main_impl.h were added. These are included in the secp256k1_bindings/include and src/modules/ellswift folders respectively, suggesting changes in existing functionality or module integration.

  • Adjustments to Object Identifiers
    Some identifiers in ObjectIdentifier.swift have seen changes. Identifiers are usually used to distinguish unique objects and changes mean that object handling is being refined.

  • Large Addition of Files for a New or Updated Feature
    Numerous files have been added to the zkp_bindings/include and src/modules. These include secp256k1_bppp.h, secp256k1_ellswift.h, secp256k1_schnorrsig_halfagg.h, bppp_norm_product_impl.h, bppp_transcript_impl.h, bppp_util.h, main.h, main_impl.h, ellswift/main_impl.h, and schnorrsig_halfagg/main_impl.h. This suggests a significant change or addition, such as a new feature or major update.

  • Update on Test Sequences
    Changes were made to the array count in secp256k1Tests.swift, which indicates an adjustment of testing scenarios. This helps ensure our software continues to perform correctly after these changes.

@csjones csjones merged commit 9683e8e into main May 13, 2024
2 checks passed
@csjones csjones deleted the ENABLE_MODULES branch May 13, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant