Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD]連続ログイン実績の追加 #527

Closed
wants to merge 2 commits into from
Closed

[ADD]連続ログイン実績の追加 #527

wants to merge 2 commits into from

Conversation

soundofhorizon
Copy link
Contributor

this issue will close #526 .

KisaragiEffective
KisaragiEffective reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles: LGTM ✅
Content: 二つ名の合意が取れているか確認できないためApproveは差し控えます

@kory33
Copy link
Member

kory33 commented Jun 9, 2020

テストをいくらか追加したので、PRのマージよりも前に develop のマージをお願いします

@kory33
Copy link
Member

kory33 commented Jul 19, 2020

こちら結局どうなりましたか

@soundofhorizon
Copy link
Contributor Author

未だにアイデア提案にて承認がいただけておらず仕様が定まっていない状態です

@Lucky3028
Copy link
Member

Lucky3028 commented Aug 3, 2020 •
edited

https://red.minecraftserver.jp/issues/8197
アイデア会議にて実装しないことが決まりました。理由などはそちらを参照してください。

@Lucky3028 Lucky3028 closed this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kory33 kory33 kory33 left review comments

@KisaragiEffective KisaragiEffective KisaragiEffective left review comments

Assignees
No one assigned
Labels
Status/Idea: Declined❌ 却下済
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

実績を追加する
4 participants
@soundofhorizon @kory33 @Lucky3028 @KisaragiEffective