stub out unstable_const feature #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
commented
Mar 26, 2024
RalfJung
changed the title
Gilnaa
approved these changes
Mar 26, 2024
|
@Gilnaa thanks! Can you do an 0.9.1 release? :) |
|
Ah, you're already on it. :D |
|
My pleasure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is pointless, nightly users get
stable_offset_ofwhich switches out the entire implementation and makes it fully const-compatible without any nightly feature.However we can avoid breaking the build of people that enable this feature, by simply making it do nothing. If they are on a ~recent nightly (less than 3 months old), they will get
stable_offset_ofwhich subsumes all the unstable features. If they are on an older nightly they should stick to older versions of memoffset.