Clockspeed: the setting now works with SimMode Car #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GimpelZhang
pushed a commit
that referenced
this pull request
Dec 21, 2020
Jony marino/pr/new issue templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
DEVELOPMENT
Description
Motivation:
(On linux, with ROS) If the density of the timestamps of the image response can raise when the clockspeed setting is tuned down, limited equipped machines can produce dense enough image streams for vslam using. Related discussion: microsoft#2369
However, this could only work with the Multirotor SimMode. SimMode Car would not response as expected, like what I described in this link: microsoft#2163
Change:
Rewrite the SimModeCar.cpp & SimModeCar.h, so physic engine used in Multirotor simmode is involved now.
To use this feature, the following settings need to be set:
Another change:
A car ros node and a keyboard control ros node added.
Related PRs
List related PRs against other branches:
Todos
Sim Environments besides Block have not been tested.
API usage of the ASimModeCar::pause / ASimModeCar::continueForTime have not been tested.