Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material UI V1 is out - breaking changes #38

Closed
charliedotau opened this issue May 19, 2018 · 6 comments
Closed

Material UI V1 is out - breaking changes #38

charliedotau opened this issue May 19, 2018 · 6 comments
Labels

Comments

@charliedotau
Copy link

Hey @Giners

It's just come to my attention that Material-UI Version 1 is finally out, and there are some breaking changes

Consequently I'm getting a compilation error, in my app that's now using MUI V1:
Module not found: Can't resolve 'material-ui/Menu' in '/..../node_modules/mui-places-autocomplete/dist

so instead of: import { MenuList, MenuItem } from 'material-ui/Menu'
you need: import { MenuList, MenuItem } from '@material-ui/core/Menu'

@Giners
Copy link
Owner

Giners commented May 21, 2018

Hey @charliedotau,

Thanks for filing this. Life has been overwhelmingly busy lately that I had no idea that v1 was finally out. 😄

I'm trying to carve out sometime to make it a priority to get this fixed now. I'm fairly certain we will rev the major version of our package as a result of this. I see also as part of the breaking changes that React 16.3 or greater is now a must as well.

I'll try to get this fixed ASAP. I've updated the import paths and the <MUIPlacesAutocomplete> component appears to work but there are other issues in the demos after updating the import paths. I haven't upgraded to React 16.3 in this project yet so hopefully that will take care of the issues.

@Giners Giners added the bug label May 21, 2018
Giners added a commit that referenced this issue May 21, 2018
This commit upgrades to the first stable release of MUI (yay!). This
commit accounts for breaking changes made in v1.0.0 of MUI. We mainly
had to account for how MUI components were imported now as well as
upgrade to React 16.3 as it is a requirement for MUI v1.0.0 now. As a
result we are also declaring this commit to be a breaking change. This
is to account for the fact that the peer dependencies have changed for
MUI as well as what versions of the peer dependencies are required for
MUI and React.

Thanks to @charliedotau and @charlax on the heads up about the new
version of MUI and the breaking changes we need to account for.
@Giners Giners closed this as completed in 2f0137f May 21, 2018
@Giners
Copy link
Owner

Giners commented May 21, 2018

Hey @charliedotau and @charlax

The issue should be fixed. Let me know if upgrading to v2.0.0 of <MUIPlacesAutocomplete> works. I'm sure you're aware since you filed the bugs but you also need to be running React at v16.3.0 or greater.

@charlax
Copy link

charlax commented May 22, 2018

Seems to be working - thanks a lot for the fix!

@Giners
Copy link
Owner

Giners commented May 22, 2018

You bet. Happy to help. 😄

@charliedotau
Copy link
Author

thanks @Giners. Working very nicely with MUI-V1. Love ya work.
thanks
Charlie

@Giners
Copy link
Owner

Giners commented May 23, 2018

Thanks @charliedotau. 😄 Promise I will try to get to the other issues once life calms down a bit. Thought it was important to get this working and unblock you and others so I woke up early to get this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants