-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material UI V1 is out - breaking changes #38
Comments
Hey @charliedotau, Thanks for filing this. Life has been overwhelmingly busy lately that I had no idea that v1 was finally out. 😄 I'm trying to carve out sometime to make it a priority to get this fixed now. I'm fairly certain we will rev the major version of our package as a result of this. I see also as part of the breaking changes that React 16.3 or greater is now a must as well. I'll try to get this fixed ASAP. I've updated the import paths and the |
This commit upgrades to the first stable release of MUI (yay!). This commit accounts for breaking changes made in v1.0.0 of MUI. We mainly had to account for how MUI components were imported now as well as upgrade to React 16.3 as it is a requirement for MUI v1.0.0 now. As a result we are also declaring this commit to be a breaking change. This is to account for the fact that the peer dependencies have changed for MUI as well as what versions of the peer dependencies are required for MUI and React. Thanks to @charliedotau and @charlax on the heads up about the new version of MUI and the breaking changes we need to account for.
Hey @charliedotau and @charlax The issue should be fixed. Let me know if upgrading to v2.0.0 of |
Seems to be working - thanks a lot for the fix! |
You bet. Happy to help. 😄 |
thanks @Giners. Working very nicely with MUI-V1. Love ya work. |
Thanks @charliedotau. 😄 Promise I will try to get to the other issues once life calms down a bit. Thought it was important to get this working and unblock you and others so I woke up early to get this fixed. |
Hey @Giners
It's just come to my attention that Material-UI Version 1 is finally out, and there are some breaking changes
Consequently I'm getting a compilation error, in my app that's now using MUI V1:
Module not found: Can't resolve 'material-ui/Menu' in '/..../node_modules/mui-places-autocomplete/dist
so instead of:
import { MenuList, MenuItem } from 'material-ui/Menu'
you need:
import { MenuList, MenuItem } from '@material-ui/core/Menu'
The text was updated successfully, but these errors were encountered: