Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that all the down/up ratio values were either 0 or 1. Tracking back to the code, the backward.size() is an int, and this.forward.size() is an int. int/int = int.
I believe the original author intended to return a proper ratio (double return type), but it doesn't look like they correctly cast one of the values to a double so to ensure correct calculation; instead they casted the value returned by integer division to a double.