-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes and cleanups #103
Various fixes and cleanups #103
Commits on Mar 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 324837c - Browse repository at this point
Copy the full SHA 324837cView commit details -
Reorder main() in code.gs so logic-flow order is more intuitive
* This is just a readability fix - with this reorder it is easier to follow "top-down" flow by reading backwards from the end of the file * Only the order in the file changed, no change of content/functionality
Configuration menu - View commit details
-
Copy full SHA for 26b170c - Browse repository at this point
Copy the full SHA 26b170cView commit details -
Rename 'Contact'->'MergedContact' to not mask Google 'Contact' object
* Even if we don't use Google's Contact object, it makes the script easier to grok for newcomers - and people like me who hadn't looked at it in a while and had forgotten, so lost time trying to understand why we were "using Google's Contact object but apparently also not" (before realizing it was not Google's Contact but our own custom Contact object). * If/when we ever want to use Google's Contact object we now just need to add "Contact" to the globals at the top and proceed.
Configuration menu - View commit details
-
Copy full SHA for c1d9b86 - Browse repository at this point
Copy the full SHA c1d9b86View commit details -
Fix date format in logging (show 24-hour)
* Use HH instead of hh in logging timestamp otherwise it is wrong half of the time as we don't use "am"/"pm" specifiers (until now e.g. 06:00 was being shown for 18:00) * Also, make time format syntax comment for testDate more explicit (DD vs. dd, etc)
Configuration menu - View commit details
-
Copy full SHA for fe101a4 - Browse repository at this point
Copy the full SHA fe101a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 610ae79 - Browse repository at this point
Copy the full SHA 610ae79View commit details -
Use lookup table for name-plurals
* This will be necessary when iterating events (not eventTypes) because certain events might have been blacklisted - commit for that coming up
Configuration menu - View commit details
-
Copy full SHA for 1a3edc5 - Browse repository at this point
Copy the full SHA 1a3edc5View commit details -
Put 'forEach(function' on one line,like all other instances of it
* This is just a whitespace formatting change (see with 'git diff --word-diff') * Aside from consistency, this is to make upcoming commit-diffs more readable due to indentation levels
Configuration menu - View commit details
-
Copy full SHA for e42511c - Browse repository at this point
Copy the full SHA e42511cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04fc6c4 - Browse repository at this point
Copy the full SHA 04fc6c4View commit details -
* Add comment explaining why as it is non-obvious due to the caller and callee being far apart
Configuration menu - View commit details
-
Copy full SHA for 1172a55 - Browse repository at this point
Copy the full SHA 1172a55View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce76418 - Browse repository at this point
Copy the full SHA ce76418View commit details
Commits on Mar 23, 2018
-
Add isIn() helper function, use it to improve readability
* I think the need for this is justified by the existence of a few false or flaky conditionals due to misuses/typos of "typeof x === y", etc. * "typeof x === 'undefined'" is not needed anyway as we aren't targetting old browsers (or browsers at all for that matter) so we don't need to worry about compatibility, and it is noticably slower than "x === undefined"
Configuration menu - View commit details
-
Copy full SHA for 4d6d247 - Browse repository at this point
Copy the full SHA 4d6d247View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9b98f2 - Browse repository at this point
Copy the full SHA e9b98f2View commit details -
In getInfoFrom..() tweak linespacing,add comments for readability
* Also fix a small typo in one of the comments
Configuration menu - View commit details
-
Copy full SHA for 0b6d0dc - Browse repository at this point
Copy the full SHA 0b6d0dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8375d64 - Browse repository at this point
Copy the full SHA 8375d64View commit details
Commits on Mar 25, 2018
-
Make getInfoFromContact also use try/catch around ID's data-fetch
* also add comments and improve error-messages, explaining why we are using the try-catch, for future reference
Configuration menu - View commit details
-
Copy full SHA for 0f74a9a - Browse repository at this point
Copy the full SHA 0f74a9aView commit details