Group blacklist #133
Open
Group blacklist #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GioBonvi
added
feature request
Users can now specify a list of groups in the settings: contacts inside those groups will be excluded from the notifications.
GioBonvi
force-pushed
the
group-blacklist
branch
from
a489aed
to
0c5f731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been contacted privately by a user suggesting that it would be nice to be able to blacklist contacts en masse using contacts groups.
I found the idea interesting as it could be implemented in parallel to the already existing blacklisting functionality to offer two different levels of control: one easier to manage and broader in scope, the other more advanced and more precise.
I thought about implementing a "default" balcklisted group by having the
blacklistedGroupsarray pre-populated as shown in the code example, but I fear it could lead to some confusion and add more problems than benefits.Leaving the users to add their own groups adds a little bit of work for them, but should be simpler to understand.
Let me know what you think.