Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix czech translation #178

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Fix czech translation #178

merged 3 commits into from
Sep 16, 2021

Conversation

phavel
Copy link
Contributor

@phavel phavel commented Sep 14, 2021

No description provided.

@plainerman
Copy link
Collaborator

Hey @phavel thank you for your first PR!

Although you are correct with changing "day/days" in czech, it would be inconsistent with other languages because we always use "days".

Could you revert those changes while keeping "zastaralou"? Then I will merge it.
If you don't have any time, just tell me, and I will do it.

Thank you for your time :)

@plainerman plainerman self-assigned this Sep 16, 2021
@phavel
Copy link
Contributor Author

phavel commented Sep 16, 2021

Hello @plainerman ,

thank you for information. However, I didn't use singular, I wrote two form for plural for czech language, it is another situation. In czech is: 1 den; 2,3,4 dny; 5-∞ dní. This is inconsistent too?

Thank you for information.

@plainerman
Copy link
Collaborator

Oh, I did not know that. I updated the version number and will merge it.

Thanks again for the PR! 🥂 👍

@plainerman plainerman merged commit 8dc0974 into GioBonvi:master Sep 16, 2021
@phavel
Copy link
Contributor Author

phavel commented Sep 16, 2021

Thanks and also thank you for your project, which is great!

@plainerman
Copy link
Collaborator

Happy that you like it, but the credit goes out to all other maintainers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants