Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add... #397

Closed
bonelifer opened this issue May 3, 2024 · 10 comments · Fixed by #399
Closed

Is it possible to add... #397

bonelifer opened this issue May 3, 2024 · 10 comments · Fixed by #399
Assignees
Labels
feature coverage Coverage for a feature from the upstream project

Comments

@bonelifer
Copy link

bonelifer commented May 3, 2024

Is it possible to add this to mpd.conf: auto_update "yes" Assuming that only causes mpd to pick up new changes and not a total update.

@GioF71 GioF71 added the feature coverage Coverage for a feature from the upstream project label May 3, 2024
@GioF71 GioF71 self-assigned this May 3, 2024
@GioF71 GioF71 linked a pull request May 3, 2024 that will close this issue
@GioF71
Copy link
Owner

GioF71 commented May 3, 2024

Added support for auto_update_depth while I were at it.
You need to add variable:

AUTO_UPDATE="yes"

for the feature you wanted to have.
Let me know if this works. Images are building right now.

@bonelifer
Copy link
Author

I'll try this once the docker image updates, didn't work when I did docker pull, so I assume it isnt done propogating/building. Got an error saying "AUTO_UPDATE="yes"" wasn't recognized and mpd never started,

@GioF71
Copy link
Owner

GioF71 commented May 4, 2024

The images have been built in a few minutes so I don't think that is the real issue. Which tag are you using?

@GioF71
Copy link
Owner

GioF71 commented May 4, 2024

Sorry I mislead you, can you try without the quotes? So AUTO_UPDATE=yes

@GioF71
Copy link
Owner

GioF71 commented May 4, 2024

Reopening, until we verify it's ok

@GioF71 GioF71 reopened this May 4, 2024
@bonelifer
Copy link
Author

It no longer complains about it. Doesn't show up in mympd or MPDroid. Don't see it in the log file. Also the log file probably from the mpd.conf, has the characters below. Making gui text editors refuse to open it thinking it's a binary.

^A^@^@^@^@^@^@

Had to use this to open this in pluma:

#!/bin/bash

# This script removes the pattern ^A^@^@^@^@^@^@ from a file using sed.

# Check if the file path is provided as an argument
if [ $# -ne 1 ]; then
    echo "Usage: $0 <file>"
    exit 1
fi

file="$1"

# Use sed to remove the specified pattern from the file
sed -i 's/\x01\x00\x00\x00\x00\x00\x00//g' "$file"

@GioF71
Copy link
Owner

GioF71 commented May 4, 2024

I saw a few mail but cannot find anything of that in the issue, maybe you deleted some posts?
Anyway in those email it looks like there was a "$" missing before the "{". It should be

      - AUTO_UPDATE=${AUTO_UPDATE:-yes}
      - ENFORCE_PLAYER_STATE=${ENFORCE_PLAYER_STATE=:-no}

instead of

      - AUTO_UPDATE={AUTO_UPDATE:-yes}
      - ENFORCE_PLAYER_STATE={ENFORCE_PLAYER_STATE=:-no}

Let me know if this helps

@GioF71
Copy link
Owner

GioF71 commented May 4, 2024

You should edit those files directly on the machine with vi or nano...
A conveniente alternative is to open vscode on your desktop computer and connect to the pi with ssh using the "Remote" extenstion. Editing becomes much easier

@bonelifer
Copy link
Author

Yes, I deleted, Sorry about that, after I noticed the things you just pointed out. AUTO_UPDATE, seems to work now. I assume the other one works as well. I have one more problem, for another issue. Thanks for the help.

@GioF71
Copy link
Owner

GioF71 commented May 4, 2024

Kind of imagined but I wanted to be sure... :-)
Please star the repo if you like the work, that is always very encouraging.
Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature coverage Coverage for a feature from the upstream project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants