[Feature] Allow spaces in names #202 (#204)

README.md

@@ -96,8 +96,8 @@ SQUEEZELITE_CODECS|-c|Please refer to the squeezelite's man page for `-c`.
 SQUEEZELITE_EXCLUDE_CODECS|-e|Please refer to the squeezelite's man page for `-e`.
 SQUEEZELITE_PRIORITY|-p|Please refer to the squeezelite's man page for `-p`.
 SQUEEZELITE_DELAY|-D|Set it to maybe something like `500,dop` if your DAC supports DoP. Defaults to `500`
-SQUEEZELITE_NAME|-n|Name of the SqueezeLite player. Use an alphanumeric string without spaces and/or special characters.
-SQUEEZELITE_MODEL_NAME|-M|Name of the SqueezeLite model name. Use an alphanumeric string without spaces and/or special characters.
+SQUEEZELITE_NAME|-n|Name of the SqueezeLite player.
+SQUEEZELITE_MODEL_NAME|-M|Name of the SqueezeLite model name.
 SQUEEZELITE_MAC_ADDRESS|-m|Mac Address of the SqueezeLite player. The format must be colon-delimited hexadecimal, for example: `ab:cd:ef:12:34:56`.
 SQUEEZELITE_TIMEOUT|-C|Device timeout in seconds, defaults to `2`
 SQUEEZELITE_SERVER_PORT|-s|Server and port of the server, for example: `squeezebox-server.local:3483` or `192.168.1.10:3483`. Do not specify the variable if you want to use the auto discovery feature. If you don't specify this variable, you will probably need to use host network mode. See the examples for some hints. The port can be omitted if not different from the default `3483`. So other possible valid values are `squeezebox-server.local` or `192.168.1.10`.

app/bin/cmd-line-builder.sh

@@ -17,7 +17,7 @@ function cmdline-player-name() {
         echo "Variable SQUEEZELITE_NAME has not been specified";
     else
         echo "Variable SQUEEZELITE_NAME has been specified: $SQUEEZELITE_NAME";
-        CMD_LINE="$CMD_LINE -n $SQUEEZELITE_NAME";
+        CMD_LINE="$CMD_LINE -n \"$SQUEEZELITE_NAME\"";
     fi
 }
 
@@ -26,7 +26,7 @@ function cmdline-model-name() {
       echo "Variable SQUEEZELITE_MODEL_NAME has not been specified";
     else
         echo "Variable SQUEEZELITE_MODEL_NAME has been specified: $SQUEEZELITE_MODEL_NAME";
-        CMD_LINE="$CMD_LINE -M $SQUEEZELITE_MODEL_NAME";
+        CMD_LINE="$CMD_LINE -M \"$SQUEEZELITE_MODEL_NAME\"";
     fi
 }
 

build.sh

@@ -93,7 +93,6 @@ else
   exit 4
 fi
 
-
 echo "Base Image: ["$expanded_base_image"]"
 echo "Download from SourceForge: ["$download"]"
 echo "Tag: ["$tag"]"

doc/release.md

@@ -10,6 +10,7 @@ Older build might be dropped in order to save space on docker-hub and incur in l
 
 Date|Type|Description
 :---|:---|:---
+2023-06-10|Player name and model allow spaces, see [#202](https://github.com/GioF71/squeezelite-docker/issues/202)
 2023-06-10|Support for custom binaries, see [#181](https://github.com/GioF71/squeezelite-docker/issues/181)
 2023-04-20|Update|Sourceforge binaries version bump
 2023-04-14|Update|Sourceforge binaries version bump