Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Simplify installer script #188

Closed
GioF71 opened this issue Mar 17, 2023 · 1 comment · Fixed by #189
Closed

[Maintenance] Simplify installer script #188

GioF71 opened this issue Mar 17, 2023 · 1 comment · Fixed by #189
Assignees
@GioF71
Labels
maintenance Maintenance task released Released

Comments

@GioF71
Copy link
Owner

GioF71 commented Mar 17, 2023 •
edited
Loading

Simplify the installer script.
We are currently building a multiline command and executing it with -c which is not very readable.
So we need to create a separate script and execute it.
Also move common operations to the Dockerfile.
@GioF71 GioF71 added the maintenance Maintenance task label Mar 17, 2023
@GioF71 GioF71 self-assigned this Mar 17, 2023
GioF71 added a commit that referenced this issue Mar 17, 2023
@GioF71
[Maintenance] Simplify installer script #188
c8d1716
@GioF71 GioF71 linked a pull request Mar 17, 2023 that will close this issue
[Maintenance] Simplify installer script #188 #189
Merged
GioF71 added a commit that referenced this issue Mar 17, 2023
@GioF71
[Maintenance] Simplify installer script #188 (#189)
2e8521c
@GioF71
Copy link
Owner Author

GioF71 commented Mar 17, 2023

Available in release 2023-03-17

@GioF71 GioF71 added the released Released label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GioF71 GioF71

Labels
maintenance Maintenance task released Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Maintenance] Simplify installer script #188 GioF71/squeezelite-docker
1 participant
@GioF71