Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Distinct builds for alsa and pulseaudio #254

Closed
GioF71 opened this issue Dec 30, 2023 · 1 comment · Fixed by #255
Closed

[Enhancement] Distinct builds for alsa and pulseaudio #254

GioF71 opened this issue Dec 30, 2023 · 1 comment · Fixed by #255
Assignees
@GioF71
Labels
enhancement New feature or request

Comments

@GioF71
Copy link
Owner

GioF71 commented Dec 30, 2023

In order to keep image size down, it would be nice to build alsa and pulseaudio only images.
The build.sh file should be updated as well.
@GioF71 GioF71 self-assigned this Dec 30, 2023
@GioF71 GioF71 added the enhancement New feature or request label Dec 30, 2023
GioF71 added a commit that referenced this issue Dec 30, 2023
@GioF71
[Enhancement] Distinct builds for alsa and pulseaudio #254
95bba6e
GioF71 added a commit that referenced this issue Dec 30, 2023
@GioF71
[Enhancement] Distinct builds for alsa and pulseaudio #254
b3e9107
GioF71 added a commit that referenced this issue Dec 30, 2023
@GioF71
[Enhancement] Distinct builds for alsa and pulseaudio #254
863c612
GioF71 added a commit that referenced this issue Dec 30, 2023
@GioF71
[Enhancement] Distinct builds for alsa and pulseaudio #254
5ef71bb
@GioF71 GioF71 linked a pull request Dec 30, 2023 that will close this issue
[Enhancement] Distinct builds for alsa and pulseaudio #254 #255
Merged
GioF71 added a commit that referenced this issue Dec 30, 2023
@GioF71
[Enhancement] Distinct builds for alsa and pulseaudio #254 (#255)
ba52271
@GioF71 GioF71 reopened this Dec 30, 2023
@GioF71
Copy link
Owner Author

GioF71 commented Dec 30, 2023

We need to pass the argument to the workflow as well

GioF71 added a commit that referenced this issue Dec 30, 2023
@GioF71
[Enhancement] Distinct builds for alsa and pulseaudio #254
ee2b0c8
GioF71 added a commit that referenced this issue Dec 30, 2023
@GioF71
[Enhancement] Distinct builds for alsa and pulseaudio #254 (#256)
b489446
@GioF71 GioF71 closed this as completed Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GioF71 GioF71

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhancement] Distinct builds for alsa and pulseaudio #254 GioF71/squeezelite-docker
1 participant
@GioF71