Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for a prefix for asound.conf #101

Closed
GioF71 opened this issue Jan 31, 2024 · 5 comments · Fixed by #102
Closed

[Feature] Add support for a prefix for asound.conf #101

GioF71 opened this issue Jan 31, 2024 · 5 comments · Fixed by #102
Assignees
Labels
enhancement New feature or request

Comments

@GioF71
Copy link
Owner

GioF71 commented Jan 31, 2024

Add ASOUND_FILE_PREFIX variable. If set, this will be used as prefix.
e.g. say that

ASOUND_FILE_PREFIX=topping-d10

instead of looking for asound.conf in userconfig, we will look for

topping-d10.asound.conf

@GioF71 GioF71 self-assigned this Jan 31, 2024
@GioF71 GioF71 added the enhancement New feature or request label Jan 31, 2024
@GioF71 GioF71 linked a pull request Jan 31, 2024 that will close this issue
@hv6478
Copy link

hv6478 commented Feb 14, 2024

Are we able to apply these settings by adding flags when creating the .env file? I see there are many lower-case references to things to update easily, but there is another list with more things that are all in CAPS. I think it may be possible to route audio through the MPD or alsa (for moOde and Volumio) so that we can use EQs or CamillaDSP with Tidal Connect. Otherwise it seems to bypass and go straight to the USB DAC. This may also help address the related open issue #74

@GioF71
Copy link
Owner Author

GioF71 commented Feb 15, 2024

Hello, I do not understand what you mean by saying

I see there are many lower-case references to things to update easily, but there is another list with more things that are all in CAPS

Are you referring to the entrypoint.sh script?

About routing to mpd, I responsed on that issue.

@hv6478
Copy link

hv6478 commented Feb 15, 2024

Hello, I do not understand what you mean by saying

I see there are many lower-case references to things to update easily, but there is another list with more things that are all in CAPS

Are you referring to the entrypoint.sh script?

About routing to mpd, I responsed on that issue.

Yes, this step:

./configure.sh -n "X20" -f "Desktop" -m "Raspberry Pi"

I can see you (very helpfully and conveniently) set many parameters that can control the variables of the entrypoint for the container. However, for something ASOUND_FILE_PREFIX I am not seeing a reference in the list of parameters to change that. I was wondering how I would indicate this, perhaps a manual write to the .env file before (re)creating with docker-compose?

Thanks again, wonderful work you are doing!

@GioF71
Copy link
Owner Author

GioF71 commented Feb 15, 2024

Hello, I do not understand what you mean by saying

I see there are many lower-case references to things to update easily, but there is another list with more things that are all in CAPS

Are you referring to the entrypoint.sh script?
About routing to mpd, I responsed on that issue.

Yes, this step:

./configure.sh -n "X20" -f "Desktop" -m "Raspberry Pi"

I can see you (very helpfully and conveniently) set many parameters that can control the variables of the entrypoint for the container. However, for something ASOUND_FILE_PREFIX I am not seeing a reference in the list of parameters to change that. I was wondering how I would indicate this, perhaps a manual write to the .env file before (re)creating with docker-compose?

Yes, of course that convenience script has not grown to cover all the functionalities that can be set with variables. To tell you the truth, I do not know how users use this compose file: do most people tweak the .env file directly, or do most people just run the script, so they expect it to cover all the features?
Does the configure.sh script make sense at all?
That said, I can definitely add support for that ASOUND_FILE_PREFIX in the configure.sh. I will do that asap.

Thanks again, wonderful work you are doing!

Thank you for the kind words.
From time to time I think about tearing down this repo, because I really don't like how the binaries (which I do not include here) have been sourced. In fact, I mention all the possible alternatives I know of in the README.md.

@hv6478
Copy link

hv6478 commented Feb 15, 2024

I notice that as well. I do enjoy tinkering and figuring things out, as I'm sure all of us do! I have a WiiM Mini out in the living room where the AVR is room-corrected and EQ is not a concern. The EQ implementation in the WiiM devices leave a LOT to be desired though. The Volumio paid integration has had many mixed reviews and with an ongoing monthly fee I do not think it's ready. I'm sure 5 years from now it will look quite different.

Regarding the script, I'm not sure otherwise but, personally, I like the configure.sh option as it's neat and tidy. I've seen you reference the option to echo different lines into it as well, so that is always good to know!

I think also the FORCE_PLAYBACK_DEVICE and CREATED_ASOUND_CARD_NAME (maybe second one not as much) could be helpful to quickly be able to configure as well. But now we are getting close to just having all of the parameters as configure.sh options LOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants