Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #162 fix #163

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Issue #162 fix #163

merged 2 commits into from
Dec 12, 2023

Conversation

jhudler
Copy link
Contributor

@jhudler jhudler commented Dec 12, 2023

Added support for special characters for schema and table names in DuckDBConnection.CreateAppender. Fixes #162

@jhudler jhudler mentioned this pull request Dec 12, 2023
Closed
Giorgi
Giorgi reviewed Dec 12, 2023
View reviewed changes
Copy link
Owner

@Giorgi Giorgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for schema with special characters?

DuckDB.NET.Data/DuckDBConnection.cs Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7183232857

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 88.5%
Totals Coverage Status
Change from base Build 7182651452: 0.02%
Covered Lines: 1282
Relevant Lines: 1419
💛 - Coveralls

@Giorgi Giorgi merged commit 3a57001 into Giorgi:develop Dec 12, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giorgi Giorgi Giorgi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DuckDBConnection.CreateAppender not dealing correctly when table with special characters
3 participants
@jhudler @coveralls @Giorgi