Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Proposal for Issue 199 #200

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Fix Proposal for Issue 199 #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3023628
Add failing test
brendonparker Jun 18, 2024
240b2ac
Make test pass
brendonparker Jun 18, 2024
9e62861
Alternative test implementation. Reduce data size from 2000 rows to 1…
brendonparker Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions DuckDB.NET.Data/Internal/Writer/ListVectorDataWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,33 +33,54 @@ internal override bool AppendCollection(ICollection value, int rowIndex)
_ = value switch
{
IEnumerable<bool> items => WriteItems(items),
IEnumerable<bool?> items => WriteItems(items),

IEnumerable<sbyte> items => WriteItems(items),
IEnumerable<sbyte?> items => WriteItems(items),
IEnumerable<short> items => WriteItems(items),
IEnumerable<short?> items => WriteItems(items),
IEnumerable<int> items => WriteItems(items),
IEnumerable<int?> items => WriteItems(items),
IEnumerable<long> items => WriteItems(items),
IEnumerable<long?> items => WriteItems(items),
IEnumerable<byte> items => WriteItems(items),
IEnumerable<byte?> items => WriteItems(items),
IEnumerable<ushort> items => WriteItems(items),
IEnumerable<ushort?> items => WriteItems(items),
IEnumerable<uint> items => WriteItems(items),
IEnumerable<uint?> items => WriteItems(items),
IEnumerable<ulong> items => WriteItems(items),
IEnumerable<ulong?> items => WriteItems(items),

IEnumerable<float> items => WriteItems(items),
IEnumerable<float?> items => WriteItems(items),
IEnumerable<double> items => WriteItems(items),
IEnumerable<double?> items => WriteItems(items),

IEnumerable<decimal> items => WriteItems(items),
IEnumerable<decimal?> items => WriteItems(items),
IEnumerable<BigInteger> items => WriteItems(items),
IEnumerable<BigInteger?> items => WriteItems(items),

IEnumerable<string> items => WriteItems(items),
IEnumerable<Guid> items => WriteItems(items),
IEnumerable<Guid?> items => WriteItems(items),
IEnumerable<DateTime> items => WriteItems(items),
IEnumerable<DateTime?> items => WriteItems(items),
IEnumerable<TimeSpan> items => WriteItems(items),
IEnumerable<TimeSpan?> items => WriteItems(items),
IEnumerable<DuckDBDateOnly> items => WriteItems(items),
IEnumerable<DuckDBDateOnly?> items => WriteItems(items),
IEnumerable<DuckDBTimeOnly> items => WriteItems(items),
IEnumerable<DuckDBTimeOnly?> items => WriteItems(items),
#if NET6_0_OR_GREATER
IEnumerable<DateOnly> items => WriteItems(items),
IEnumerable<DateOnly?> items => WriteItems(items),
IEnumerable<TimeOnly> items => WriteItems(items),
IEnumerable<TimeOnly?> items => WriteItems(items),
#endif
IEnumerable<DateTimeOffset> items => WriteItems(items),
IEnumerable<DateTimeOffset?> items => WriteItems(items),

_ => WriteItems<object>((IEnumerable<object>)value)
};
Expand Down
8 changes: 7 additions & 1 deletion DuckDB.NET.Test/DuckDBManagedAppenderListTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,15 @@ public void ArrayValuesInt()
ListValuesInternal("Integer", faker => faker.Random.Int(), 5);
}

[Fact]
public void ListValuesNullableDouble()
{
ListValuesInternal("Double", faker => faker.Random.Double().OrNull(faker));
}

private void ListValuesInternal<T>(string typeName, Func<Faker, T> generator, int? length = null)
{
var rows = 2000;
var rows = 10;
var table = $"managedAppenderLists";

var columnLength = length.HasValue ? length.Value.ToString() : "";
Expand Down