Fix tests for DuckDB v5 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know if that is a new feature in 0.5.0 or a bug? I asked it here but didn't get any response: duckdb/duckdb#4640 |
|
This seems to be a feature, an optimisation of some kind. DuckDB ignores any UPDATE statement for an empty table, not only erroneous. As you can see from the PR, I've updated tests that use the correct parameter order, as they reported no affected rows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have failing builds. The reason is that the tests with UPDATE statements and invalid parameter values are failing. Apparently, that is because DuckDB does not execute UPDATE statements on empty tables.