Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null handling #64

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Fix null handling #64

merged 1 commit into from
Sep 21, 2022

Conversation

unconverged
Copy link
Contributor

This PR fixes a serious bug with null value handling. We simply were not able to use null values as parameter values.

I think we should upload a new nuget version, as this bug makes it impossible to use the binding library in some cases.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3098165470

  • 0 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 85.465%

Totals Coverage Status
Change from base Build 3088582276: 0.3%
Covered Lines: 588
Relevant Lines: 680

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3098165470

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 85.465%

Totals Coverage Status
Change from base Build 3088582276: 0.3%
Covered Lines: 588
Relevant Lines: 680

💛 - Coveralls

@Giorgi Giorgi merged commit 1c5116e into Giorgi:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants