Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Colors.jl v0.10 #380

Closed
kimikage opened this issue Jan 7, 2020 · 6 comments · Fixed by #381
Closed

Adding support for Colors.jl v0.10 #380

kimikage opened this issue Jan 7, 2020 · 6 comments · Fixed by #381

Comments

@kimikage
Copy link

kimikage commented Jan 7, 2020

I am currently working on making Gadfly.jl compatible with Colors.jl v0.11 (and v0.10).
(cf. GiovineItalia/Gadfly.jl#1368, GiovineItalia/Gadfly.jl#1369)

There is no reason to exclude Colors v0.10 from the [compat] entry, since the compatibility with Colors.jl in Gadfly.jl is capped at v0.9.
https://github.com/GiovineItalia/Gadfly.jl/blob/bf50828f8603ab0b4f918b5247d9c99186960876/Project.toml#L31-L34

In fact, the current master (20485b1) seems to be compatible with Colors.jl v0.10
https://travis-ci.org/kimikage/Compose.jl/builds/633591993

Of course, since Colors.jl v0.11 is already supported, adding support for Colors.jl v0.10 has little benefit for end users. So, this is just a matter of making the dependencies reasonable.

@Mattriks
Copy link
Member

Mattriks commented Jan 7, 2020

Is the use of color names in Colors v0.10, consistent with the use of color names in Colors v0.9.x and Colors v0.11? Even if Compose passes testing with Colors v0.10, are there other reasons that we might not want to support it?

@kimikage
Copy link
Author

kimikage commented Jan 7, 2020

use of color names

other reasons that we might not want to support v0.10

  • The downstream packages need to be checked for the compatibility with Colors v0.10.
    • However, I don't think it is a problem for higher-level packages like Compose.jl.
  • Colors v0.1x, not just v0.10, are the preparations to release Colors v1.0 and probably have a short support period.

@bjarthur
Copy link
Member

@Mattriks are you arguing that we should not add Colors 0.10 to Compose? my shallow understanding is that it is just a change in the permitted color names, and if Compose does not use them directly, but just passes them through from the user, then we should permit that.

@kimikage
Copy link
Author

In addition, there are actually many differences between v0.9.6 and v0.10, other than color names.

However, the important thing is that v0.10 and v0.11 are functionally identical. The difference is the renames of the rarely used types, RGB1 and RGB4.

@Mattriks
Copy link
Member

@bjarthur We need to add a link to the Compose and Gadfly docs about the allowed color names:
http://juliagraphics.github.io/Colors.jl/latest/namedcolors/

@ben-schulz
Copy link

submitted a relevant pull request in response to issue #1374;

sorry, meant to reference this issue instead, as @bjarthur originally requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants