Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish port to julia 0.6 #240

Merged
merged 6 commits into from
Apr 7, 2017
Merged

finish port to julia 0.6 #240

merged 6 commits into from
Apr 7, 2017

Conversation

bjarthur
Copy link
Member

@bjarthur bjarthur commented Apr 6, 2017

this simply adds one more commit to #239 which removes the remaining dep warns. one can now cleanly using Compose on julia 0.5 and 0.6.

while tests pass on 0.6, they currently don't for 0.5, neither for the master branch of Compose nor this PR:

julia> Pkg.test("Compose")
INFO: Computing test dependencies for Compose...
INFO: No packages to install, update or remove
INFO: Testing Compose
Test Failed
  Expression: ((text_extents(font_family,8pt,"test test"))[1])[2] * 2 == ((text_extents(font_family,8pt,"test\ntest"))[1])[2]
   Evaluated: 3.7758246527777772mm == 5.206917317708333mm

but that is a separate issue...

@bjarthur
Copy link
Member Author

bjarthur commented Apr 6, 2017

tests pass on 0.5 and nightly. will merge in a couple days unless someone has a concern.

the text_extents failure mentioned above appears to be something peculiar to my local machine. i also experience another failure locally involving small differences in the generated .svg files which have no impact on the visual appearance. but travis is happy, so so am i.

@tlnagy
Copy link
Member

tlnagy commented Apr 6, 2017

@bjarthur Thanks for taking the time to update my PR. I'm working on getting Measures.jl working right now. It looks like we're closing in on getting the Gadfly stack onto 0.6! 🎉

@tlnagy
Copy link
Member

tlnagy commented Apr 6, 2017

Also, the text_extents failures could be due to you having slightly different fonts being used then the Travis Linux boxes.

@bjarthur
Copy link
Member Author

bjarthur commented Apr 6, 2017

i've got measures working already. just need to push the PR

@tlnagy
Copy link
Member

tlnagy commented Apr 6, 2017

Ah. Well I have PR here: JuliaGraphics/Measures.jl#12 waiting for it to pass tests.

@bjarthur bjarthur merged commit 7ea1616 into master Apr 7, 2017
@bjarthur bjarthur deleted the bja/more-fixes-0.6 branch April 7, 2017 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants