Skip to content

Commit

Permalink
Fixed Entity attribute warning on newer versions of Forge
Browse files Browse the repository at this point in the history
Fixed empty include/exclude config being seen as invalid
  • Loading branch information
GirafiStudios committed Feb 25, 2021
1 parent f7acce6 commit 189d34f
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 9 deletions.
6 changes: 3 additions & 3 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
minecraft_version=1.16.4
forge_version=35.0.15
minecraft_version=1.16.5
forge_version=36.0.43
mappings=20201028-1.16.3
mod_version=0.8.11
mod_version=0.8.12

org.gradle.jvmargs=-Xmx4G
org.gradle.daemon=false
7 changes: 6 additions & 1 deletion src/main/java/com/girafi/waddles/init/PenguinRegistry.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.gen.Heightmap;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.event.entity.EntityAttributeCreationEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;

Expand Down Expand Up @@ -46,7 +47,11 @@ public static void registerPenguins(RegistryEvent.Register<EntityType<?>> event)
event.getRegistry().register(entity);
EntitySpawnPlacementRegistry.register(entity, EntitySpawnPlacementRegistry.PlacementType.ON_GROUND, Heightmap.Type.MOTION_BLOCKING_NO_LEAVES, AdeliePenguinEntity::canPenguinSpawn);
}
GlobalEntityTypeAttributes.put(ADELIE_PENGUIN, AdeliePenguinEntity.getAttributes().create());
}

@SubscribeEvent
public static void addEntityAttributes(EntityAttributeCreationEvent event) {
event.put(ADELIE_PENGUIN, AdeliePenguinEntity.getAttributes().create());
}

@SubscribeEvent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public static class General {
.comment("Penguins should drop experience?")
.translation("waddles.configgui.dropExp")
.define("dropExp", true);
spawnBlocks = builder.defineList("spawn blocks", Collections.singletonList(Blocks.GRASS_BLOCK.getRegistryName().toString()),o -> ForgeRegistries.BLOCKS.getKeys().contains(new ResourceLocation(String.valueOf(o))));
spawnBlocks = builder.defineList("spawn blocks", Collections.singletonList(Blocks.GRASS_BLOCK.getRegistryName().toString()), o -> o instanceof String && ForgeRegistries.BLOCKS.getKeys().contains(new ResourceLocation(o.toString())));
builder.pop();
}
}
Expand All @@ -52,8 +52,8 @@ public static class Spawn {
weight = builder.defineInRange("weight", 7, 0, 100);
builder.pop();
builder.push("spawnable biomes");
include = builder.defineList("include", Collections.singletonList(SNOWY.toString()), o -> BiomeDictionary.Type.getAll().contains(BiomeDictionaryHelper.getType(String.valueOf(o))));
exclude = builder.defineList("exclude", Arrays.asList(FOREST.toString(), MOUNTAIN.toString(), OCEAN.toString(), NETHER.toString()), o -> BiomeDictionary.Type.getAll().contains(BiomeDictionaryHelper.getType(String.valueOf(o))));
include = builder.defineList("include", Collections.singletonList(SNOWY.toString()), o -> o instanceof String && (o.equals("") || BiomeDictionary.Type.getAll().contains(BiomeDictionaryHelper.getType(o.toString()))));
exclude = builder.defineList("exclude", Arrays.asList(FOREST.toString(), MOUNTAIN.toString(), OCEAN.toString(), NETHER.toString()), o -> o instanceof String && (o.equals("") || BiomeDictionary.Type.getAll().contains(BiomeDictionaryHelper.getType(o.toString()))));
builder.pop();
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/META-INF/mods.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
modLoader="javafml"
loaderVersion="[34,)"
loaderVersion="[36,)"
logoFile="logo.png"
license="GNU General Public License v3.0"

Expand All @@ -18,6 +18,6 @@ license="GNU General Public License v3.0"
[[dependencies.waddles]]
modId="forge"
mandatory=true
versionRange="[34.1.21,)"
versionRange="[36.0.42,)"
ordering="AFTER"
side="BOTH"

0 comments on commit 189d34f

Please sign in to comment.